kitchen: add -python-path

kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: special
treatment of PYTHONPATH would be more special in swarming than in 
kitchen because swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269
Committed: https://github.com/luci/luci-go/commit/b1931833114a989a4e278398fd214dea83d1ca89

[nodir, 2016-06-29 16:09:46]

Description was changed from

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: support
for PYTHONPATH would be more special in swarming than in kitchen because
swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=
==========

to

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: support
for PYTHONPATH would be more special in swarming than in kitchen because
swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269
==========

[nodir, 2016-06-29 16:10:48]

Description was changed from

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: support
for PYTHONPATH would be more special in swarming than in kitchen because
swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269
==========

to

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: special
treatment of PYTHONPATH would be more special in swarming than in 
kitchen because swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269
==========

[nodir, 2016-06-29 16:41:36]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 16:41:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 16:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 16:46:40]

Dry run: Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester (Swarming) on master.tryserver.infra
(JOB_FAILED, https://luci-milo.appspot.com/swarming/prod/2fb5db7396631f10)
  Luci-go Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Trust...)
  Luci-go Linux Trusty 64 Tester (Swarming) on master.tryserver.infra
(JOB_FAILED, https://luci-milo.appspot.com/swarming/prod/2fb5db74465f5f10)

[nodir, 2016-06-29 17:09:18]

The CQ bit was checked by nodir@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 17:09:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 17:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 17:19:43]

Dry run: This issue passed the CQ dry run.

[nodir, 2016-06-30 14:31:21]

Ptal

[nodir, 2016-07-01 16:11:26]

ping

[estaab, 2016-07-01 18:46:05]

lgtm

[nodir, 2016-07-01 20:10:13]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-07-01 20:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 20:19:19]

Description was changed from

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: special
treatment of PYTHONPATH would be more special in swarming than in 
kitchen because swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269
==========

to

==========
kitchen: add -python-path

Problem: swarming_task_template specified PYTHONPATH env variable to a
path relative to run dir because it cannot specify absolute path. It
breaks during task execution as soon as cwd is changed, e.g. when
kitchen runs recipes.py.

Fixing this problem at swarming level is a bit controversial: special
treatment of PYTHONPATH would be more special in swarming than in 
kitchen because swarming is more general than kitchen.

Fix it by adding explicit support for python paths in kitchen: make them
absolute and set env variable.

R=estaab@chromium.org
BUG=623269

Committed:
https://github.com/luci/luci-go/commit/b1931833114a989a4e278398fd214dea83d1ca89
==========

[commit-bot: I haz the power, 2016-07-01 20:19:21]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/b1931833114a989a4e278398fd214dea83d1ca89