[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be necessary
for correctness. If removing this call affects performance negatively, we can revert
this CL.

Committed: https://crrev.com/5d8cfbbd06d04e218a116f9176d278bcd21d9a9b
Cr-Commit-Position: refs/heads/master@{#37422}

[ahaas, 2016-06-30 08:32:47]

Description was changed from

==========
Remove string flattening.

BUG=
==========

to

==========
The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

[ahaas, 2016-06-30 08:32:47]

ahaas@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[titzer, 2016-06-30 08:35:32]

lgtm

[Benedikt Meurer, 2016-06-30 08:36:11]

Description was changed from

==========
The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

to

==========
[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

[Benedikt Meurer, 2016-06-30 08:36:21]

LGTM, thanks.

[ahaas, 2016-06-30 08:36:31]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-06-30 08:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 08:38:42]

Description was changed from

==========
[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

to

==========
[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

[commit-bot: I haz the power, 2016-06-30 08:38:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 08:38:45]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 08:41:22]

Description was changed from

==========
[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary 
for correctness. If removing this call affects performance negatively, we can
revert
this CL.
==========

to

==========
[turbofan] Don't call String::Flatten in Constant::ToHeapObject()

The call to String::Flatten can cause garbage collection and in general adds
complexity to the code generation. It also blocks the way to run code generation
on worker threads.

The call to String::Flatten in Constant::ToHeapObject() seems not to be
necessary
for correctness. If removing this call affects performance negatively, we can
revert
this CL.

Committed: https://crrev.com/5d8cfbbd06d04e218a116f9176d278bcd21d9a9b
Cr-Commit-Position: refs/heads/master@{#37422}
==========

[commit-bot: I haz the power, 2016-06-30 08:41:23]

Patchset 1 (id:??) landed as
https://crrev.com/5d8cfbbd06d04e218a116f9176d278bcd21d9a9b
Cr-Commit-Position: refs/heads/master@{#37422}