third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2107233002: Reland "Implement FullScreen using top layer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2107233002: Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: restore !important to overflow:hidden Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 10897245dab43bf655cf30e9ef7aeae6ede030ae..77e0ffe0c00a8f84e6c8c483c11f8fba56dfd3b3 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1796,8 +1796,7 @@ void FrameView::clearLayoutSubtreeRootsAndMarkContainingBlocks()

void FrameView::addOrthogonalWritingModeRoot(LayoutBox& root)

{

- ASSERT(!root.isLayoutFullScreen() && !root.isLayoutFullScreenPlaceholder()

- && !root.isLayoutScrollbarPart());

+ DCHECK(!root.isLayoutScrollbarPart());

m_orthogonalWritingModeRootList.add(root);

}