Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 2107233002: Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: new untested DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FullscreenController.cpp
diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp
index 0b506896f046d519abcab5fe8dbf9e31e5dcbf0e..1bae36ff4b436c30d58968c72729a1267a63e0b4 100644
--- a/third_party/WebKit/Source/web/FullscreenController.cpp
+++ b/third_party/WebKit/Source/web/FullscreenController.cpp
@@ -37,7 +37,6 @@
#include "core/frame/PageScaleConstraintsSet.h"
#include "core/html/HTMLMediaElement.h"
#include "core/html/HTMLVideoElement.h"
-#include "core/layout/LayoutFullScreen.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "public/platform/WebLayerTreeView.h"
#include "public/web/WebFrameClient.h"
@@ -131,6 +130,13 @@ void FullscreenController::didExitFullscreen()
void FullscreenController::enterFullScreenForElement(Element* element)
{
+ // TODO(dsinclair): This should not be needed because we addToTopLayer
+ // in Fullscreen::pushFullscreenElementStack but, the WebView code doesn't
+ // call Fullscreen::requestFullscreen() and, instead, just enters and
+ // exists itself. This should be unified so there is one way to go
+ // fullscreen. crbug.com/538158
+ element->document().addToTopLayer(element);
+
// We are already transitioning to fullscreen for a different element.
if (m_provisionalFullScreenElement) {
m_provisionalFullScreenElement = element;
@@ -166,6 +172,13 @@ void FullscreenController::exitFullScreenForElement(Element* element)
{
DCHECK(element);
+ // TODO(dsinclair): This should not be needed because we addToTopLayer
+ // in Fullscreen::popFullscreenElementStack but, the WebView code doesn't
+ // call Fullscreen::requestFullscreen() and, instead, just enters and
+ // exists itself. This should be unified so there is one way to go
+ // fullscreen. crbug.com/538158
+ element->document().removeFromTopLayer(element);
+
// The client is exiting full screen, so don't send a notification.
if (m_isCancelingFullScreen)
return;
@@ -182,9 +195,9 @@ void FullscreenController::updateSize()
updatePageScaleConstraints(false);
- LayoutFullScreen* layoutObject = Fullscreen::from(*m_fullScreenFrame->document()).fullScreenLayoutObject();
- if (layoutObject)
- layoutObject->updateStyle();
+ Document* document = m_fullScreenFrame->document();
+ if (Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document))
+ Fullscreen::from(fullscreenElement->document()).didUpdateSize(*fullscreenElement);
}
void FullscreenController::updatePageScaleConstraints(bool removeConstraints)
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LayoutItem.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698