third_party/WebKit/Source/core/dom/Document.cpp - Issue 2107233002: Reland "Implement FullScreen using top layer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2107233002: Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new untested DCHECK Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 8ed3874c6cb42ba1c1c0a98de220ed8b4775be8f..23e960ac4327708ffd30d9b1f1caa7985a876507 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -5303,9 +5303,12 @@ void Document::removeFromTopLayer(Element* element)

HTMLDialogElement* Document::activeModalDialog() const

{

- if (m_topLayerElements.isEmpty())

- return 0;

- return toHTMLDialogElement(m_topLayerElements.last().get());

+ for (auto it = m_topLayerElements.rbegin(); it != m_topLayerElements.rend(); ++it) {

+ if (isHTMLDialogElement(*it))

+ return toHTMLDialogElement((*it).get());

+ }

+ return nullptr;

}

void Document::exitPointerLock()