third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp - Issue 2107233002: Reland "Implement FullScreen using top layer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2107233002: Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new untested DCHECK Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

index 21f77974b4d1972111d3706080b499877612f2c9..d98cbd86379dc88a892b72ac056d17a23686a3f3 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

@@ -887,7 +887,10 @@ PseudoElement* StyleResolver::createPseudoElementIfNeeded(Element& parent, Pseud

if (pseudoId == PseudoIdFirstLetter && (parent.isSVGElement() || !FirstLetterPseudoElement::firstLetterTextLayoutObject(parent)))

return nullptr;

- if (!canHaveGeneratedChildren(*parentLayoutObject))

+ // The backdrop pseudo element generates a new stacking context and its

+ // layout object does not become a child of |parentLayoutObject|. The

+ // exemption is needed so that replaced content also gets a backdrop.

+ if (pseudoId != PseudoIdBackdrop && !canHaveGeneratedChildren(*parentLayoutObject))

return nullptr;

ComputedStyle* parentStyle = parentLayoutObject->mutableStyle();