Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2107233002: Reland "Implement FullScreen using top layer." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: new untested DCHECK Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 while (beforeDescendantContainer->parent() != this) 251 while (beforeDescendantContainer->parent() != this)
252 beforeDescendantContainer = beforeDescendantContainer->parent(); 252 beforeDescendantContainer = beforeDescendantContainer->parent();
253 ASSERT(beforeDescendantContainer); 253 ASSERT(beforeDescendantContainer);
254 254
255 // We really can't go on if what we have found isn't anonymous. We're not su pposed to use some 255 // We really can't go on if what we have found isn't anonymous. We're not su pposed to use some
256 // random non-anonymous object and put the child there. That's a recipe for security issues. 256 // random non-anonymous object and put the child there. That's a recipe for security issues.
257 RELEASE_ASSERT(beforeDescendantContainer->isAnonymous()); 257 RELEASE_ASSERT(beforeDescendantContainer->isAnonymous());
258 258
259 // If the requested insertion point is not one of our children, then this is because 259 // If the requested insertion point is not one of our children, then this is because
260 // there is an anonymous container within this object that contains the befo reDescendant. 260 // there is an anonymous container within this object that contains the befo reDescendant.
261 if (beforeDescendantContainer->isAnonymousBlock() 261 if (beforeDescendantContainer->isAnonymousBlock()) {
262 // Full screen layoutObjects and full screen placeholders act as anonymo us blocks, not tables:
263 || beforeDescendantContainer->isLayoutFullScreen()
264 || beforeDescendantContainer->isLayoutFullScreenPlaceholder()) {
265 // Insert the child into the anonymous block box instead of here. 262 // Insert the child into the anonymous block box instead of here.
266 if (newChild->isInline() || newChild->isFloatingOrOutOfFlowPositioned() || beforeDescendant->parent()->slowFirstChild() != beforeDescendant) 263 if (newChild->isInline() || newChild->isFloatingOrOutOfFlowPositioned() || beforeDescendant->parent()->slowFirstChild() != beforeDescendant)
267 beforeDescendant->parent()->addChild(newChild, beforeDescendant); 264 beforeDescendant->parent()->addChild(newChild, beforeDescendant);
268 else 265 else
269 addChild(newChild, beforeDescendant->parent()); 266 addChild(newChild, beforeDescendant->parent());
270 return; 267 return;
271 } 268 }
272 269
273 ASSERT(beforeDescendantContainer->isTable()); 270 ASSERT(beforeDescendantContainer->isTable());
274 if (newChild->isTablePart()) { 271 if (newChild->isTablePart()) {
(...skipping 1591 matching lines...) Expand 10 before | Expand all | Expand 10 after
1866 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) { 1863 for (TrackedLayoutBoxListHashSet::const_iterator it = positionedDescenda ntSet->begin(); it != end; ++it) {
1867 LayoutBox* currBox = *it; 1864 LayoutBox* currBox = *it;
1868 ASSERT(!currBox->needsLayout()); 1865 ASSERT(!currBox->needsLayout());
1869 } 1866 }
1870 } 1867 }
1871 } 1868 }
1872 1869
1873 #endif 1870 #endif
1874 1871
1875 } // namespace blink 1872 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698