Reland "Implement FullScreen using top layer."

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 5287 matching lines @@
     if (!element->isInTopLayer())
         return;
     size_t position = m_topLayerElements.find(element);
     DCHECK_NE(position, kNotFound);
     m_topLayerElements.remove(position);
     element->setIsInTopLayer(false);
 }
 
 HTMLDialogElement* Document::activeModalDialog() const
 {
-    if (m_topLayerElements.isEmpty())
-        return 0;
-    return toHTMLDialogElement(m_topLayerElements.last().get());
+    for (auto it = m_topLayerElements.rbegin(); it != m_topLayerElements.rend(); ++it) {

[eae, 2016/07/12 17:09:49]

Why are we iterating backwards here?

[foolip, 2016/07/12 20:19:48]

This is merely because the end of the m_topLayerElements vector is treated as
the top of the top layer stack. In Document::addToTopLayer one can see this, and
I assume it's because pushing/popping at the end of the vector is more
efficient. I'll document this in Document.h.

+        if (isHTMLDialogElement(*it))
+            return toHTMLDialogElement((*it).get());
+    }
+
+    return nullptr;
 }
 
 void Document::exitPointerLock()
 {
     if (!page())
         return;
     if (Element* target = page()->pointerLockController().element()) {
         if (target->document() != this)
             return;
         page()->pointerLockController().requestPointerUnlock();
@@ skipping 713 matching lines @@
 }
 
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().getString().utf8().data());
 }
 #endif