src/crankshaft/arm/lithium-codegen-arm.cc - Issue 2107193002: [ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 2107193002: [ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible to ... (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebasing on top of Issue 2127583002 Patch 120001 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index db80aadaa1dd340838593cad178f400ca4d104a9..77b8bb143849143d9fd11aec223e87c3d9b7f96b 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -3223,6 +3223,8 @@ void LCodeGen::DoDeclareGlobals(LDeclareGlobals* instr) {

__ push(scratch0());

__ mov(scratch0(), Operand(Smi::FromInt(instr->hydrogen()->flags())));

__ push(scratch0());

+ __ Move(scratch0(), instr->hydrogen()->feedback_vector());

+ __ push(scratch0());

CallRuntime(Runtime::kDeclareGlobals, instr);

}

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »