Add the future storage framework for the BudgetDatabase.

chrome/browser/budget_service/budget_database_unittest.cc

Index: chrome/browser/budget_service/budget_database_unittest.cc
diff --git a/chrome/browser/budget_service/budget_database_unittest.cc b/chrome/browser/budget_service/budget_database_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dd08a0e4b3a88f5ca365fde824c6e475eb980d26
--- /dev/null
+++ b/chrome/browser/budget_service/budget_database_unittest.cc
@@ -0,0 +1,102 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/budget_service/budget_database.h"
+
+#include "base/run_loop.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/budget_service/budget.pb.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/leveldb_proto/proto_database.h"
+#include "components/leveldb_proto/proto_database_impl.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// Name of the directory where the budget database is stored on disk.
+const char kDatabaseFileDir[] = "BudgetDatabase";
+
+const double kDefaultDebt = -0.72;
+const double kDefaultBudget1 = 1.234;
+const double kDefaultBudget2 = 2.345;
+const double kDefaultExpiration = 3600000000;
+
+const char kTestOrigin[] = "https://example.com";
+
+class BudgetDatabaseTest : public ::testing::Test {
+ public:
+  BudgetDatabaseTest()
+      : success_(false),
+        db_(profile_.GetPath().Append(FILE_PATH_LITERAL(kDatabaseFileDir)),

[Peter Beverloo, 2016/06/30 13:12:46]

A constant is not a literal :-). You use FILE_PATH_LITERAL *only* with actual C
strings, because it'll expand the string at compile-time on Windows.

Just inline "BudgetDatabase" here instead of using a constant.

[harkness, 2016/07/01 12:29:54]

hah! That's what I get for trying to clean things up before sending them out for
code review. Although it's odd that this only causes the try builds to fail, and
not my local build.

+            base::ThreadTaskRunnerHandle::Get()) {}
+
+  void SetBudgetComplete(base::Closure run_loop_closure, bool success) {
+    success_ = success;
+    run_loop_closure.Run();
+  }
+
+  // Set up basic default values.
+  bool SetBudgetWithDefaultValues() {
+    budget_service::Budget b;

[Peter Beverloo, 2016/06/30 13:12:46]

nit re: b, bc1, bc2: please don't use such acronyms in Chromium, even in testing
code. (Also on line 93.)

Silly as may be, we're trying hard to stay consistent here, which already is
tricky with a large code base (as you found out with the protobuf's namespace
name!)

[harkness, 2016/07/01 12:29:54]

Done.

+    b.set_debt(kDefaultDebt);
+    budget_service::BudgetChunk* bc1 = b.add_budget();
+    bc1->set_budget_amount(kDefaultBudget1);
+    bc1->set_expiration_timestamp(kDefaultExpiration);
+    budget_service::BudgetChunk* bc2 = b.add_budget();
+    bc2->set_budget_amount(kDefaultBudget2);
+    bc2->set_expiration_timestamp(kDefaultExpiration + 1);
+
+    base::RunLoop run_loop;
+    db_.SetValue(GURL(kTestOrigin), b,
+                 base::Bind(&BudgetDatabaseTest::SetBudgetComplete,
+                            base::Unretained(this), run_loop.QuitClosure()));
+    run_loop.Run();
+
+    return success_;
+  }
+
+  void GetBudgetComplete(base::Closure run_loop_closure,
+                         bool success,
+                         std::unique_ptr<budget_service::Budget> budget) {
+    budget_ = std::move(budget);
+    success_ = success;
+    run_loop_closure.Run();
+  }
+
+  // Excercise the very basic get method.
+  std::unique_ptr<budget_service::Budget> GetBudget() {
+    base::RunLoop run_loop;
+    db_.GetValue(GURL(kTestOrigin),
+                 base::Bind(&BudgetDatabaseTest::GetBudgetComplete,
+                            base::Unretained(this), run_loop.QuitClosure()));
+    run_loop.Run();
+    return std::move(budget_);
+  }
+
+  Profile* profile() { return &profile_; }
+
+ protected:
+  bool success_;
+
+ private:
+  content::TestBrowserThreadBundle thread_bundle_;
+  std::unique_ptr<budget_service::Budget> budget_;
+  TestingProfile profile_;
+  BudgetDatabase db_;
+};
+
+TEST_F(BudgetDatabaseTest, ReadAndWriteTest) {
+  ASSERT_TRUE(SetBudgetWithDefaultValues());
+  std::unique_ptr<budget_service::Budget> b = GetBudget();
+
+  ASSERT_TRUE(success_);
+  EXPECT_EQ(kDefaultDebt, b->debt());
+  EXPECT_EQ(kDefaultBudget1, b->budget(0).budget_amount());
+  EXPECT_EQ(kDefaultBudget2, b->budget(1).budget_amount());
+  EXPECT_EQ(kDefaultExpiration, b->budget(0).expiration_timestamp());
+}
+
+}  // namespace