Add the future storage framework for the BudgetDatabase.

chrome/browser/budget_service/budget_database_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/budget_service/budget_database.h"
+
+#include "base/run_loop.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/budget_service/budget.pb.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/leveldb_proto/proto_database.h"
+#include "components/leveldb_proto/proto_database_impl.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+// Name of the directory where the budget database is stored on disk.
+const char kDatabaseFileDir[] = "BudgetDatabase";
+
+const double kDefaultDebt = -0.72;
+const double kDefaultBudget1 = 1.234;
+const double kDefaultBudget2 = 2.345;
+const double kDefaultExpiration = 3600000000;
+
+using chrome_browser_budget_service::Budget;
+using chrome_browser_budget_service::BudgetChunk;
+
+const char kTestOrigin[] = "https://example.com";
+
+class BudgetDatabaseTest : public ::testing::Test {
+ public:
+  BudgetDatabaseTest()
+      : success_(false),
+        db_(profile_.GetPath().Append(FILE_PATH_LITERAL(kDatabaseFileDir)),
+            base::ThreadTaskRunnerHandle::Get()) {}
+
+  void SetBudgetComplete(base::Closure run_loop_closure, bool success) {
+    success_ = success;
+    run_loop_closure.Run();
+  }
+
+  // Set up basic default values.
+  bool SetBudgetWithDefaultValues() {
+    Budget b;
+    b.set_debt(kDefaultDebt);
+    BudgetChunk* bc1 = b.add_budget();
+    bc1->set_budget_amount(kDefaultBudget1);
+    bc1->set_expiration_timestamp(kDefaultExpiration);
+    BudgetChunk* bc2 = b.add_budget();
+    bc2->set_budget_amount(kDefaultBudget2);
+    bc2->set_expiration_timestamp(kDefaultExpiration + 1);
+
+    base::RunLoop run_loop;
+    db_.SetValue(GURL(kTestOrigin), b,
+                 base::Bind(&BudgetDatabaseTest::SetBudgetComplete,
+                            base::Unretained(this), run_loop.QuitClosure()));
+    run_loop.Run();
+
+    return success_;
+  }
+
+  void GetBudgetComplete(base::Closure run_loop_closure,
+                         bool success,
+                         std::unique_ptr<Budget> budget) {
+    budget_ = std::move(budget);
+    success_ = success;
+    run_loop_closure.Run();
+  }
+
+  // Excercise the very basic get method.
+  std::unique_ptr<Budget> GetBudget() {
+    base::RunLoop run_loop;
+    db_.GetValue(GURL(kTestOrigin),
+                 base::Bind(&BudgetDatabaseTest::GetBudgetComplete,
+                            base::Unretained(this), run_loop.QuitClosure()));
+    run_loop.Run();
+    return std::move(budget_);
+  }
+
+  Profile* profile() { return &profile_; }
+
+  content::TestBrowserThreadBundle thread_bundle_;
+  bool success_;

[Peter Beverloo, 2016/06/29 13:37:28]

|thread_bundle_| should be private.
|success_| should be protected.

[harkness, 2016/06/30 10:41:57]

Done.

+
+ private:
+  std::unique_ptr<Budget> budget_;
+  TestingProfile profile_;
+  BudgetDatabase db_;
+};
+
+TEST_F(BudgetDatabaseTest, ReadAndWriteTest) {
+  ASSERT_TRUE(SetBudgetWithDefaultValues());
+  std::unique_ptr<Budget> b = GetBudget();
+
+  ASSERT_TRUE(success_);
+  EXPECT_EQ(kDefaultDebt, b->debt());
+  EXPECT_EQ(kDefaultBudget1, b->budget(0).budget_amount());
+  EXPECT_EQ(kDefaultBudget2, b->budget(1).budget_amount());
+  EXPECT_EQ(kDefaultExpiration, b->budget(0).expiration_timestamp());
+}

[Peter Beverloo, 2016/06/29 13:37:28]

What is your plan with this class? Will there be other unit tests?

You have generalized a lot of logic in the BudgetDatabaseTest class now, while
there's only one test using it. That's something we usually only do for tests
when there are several.

[harkness, 2016/06/30 10:41:57]

I'm assuming there will be at least another 3-4 tests. For instance, I will need
to add budget to origins. Right now, the caller would have to read the budget,
append another BudgetChunk, then write it back. I'm planning to add a method on
the BudgetDatabase which would wrap that, and then I'd need a test for that.

I'm also going to need to do a periodic cleanup, which I'm planning to put on
the BudgetDatabase, etc.

+
+}  // namespace