Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2107163003: Remove calls to deprecated MessageLoop methods in third_party. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
agl, dglazkov, Evan Stade
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in third_party. This CL makes the following replacements in third_party: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. TBR=dglazkov@chromium.org,estade@chromium.org,agl@chromium.org BUG=616447 Committed: https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2 Cr-Commit-Position: refs/heads/master@{#402847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_address_validator.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fdoray
dglazkov@chromium.org: Can you review Webkit changes? estade@chromium.org: Can you review libaddressinput changes? agl@chromium.org: Can you ...
4 years, 5 months ago (2016-06-29 15:55:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107163003/1
4 years, 5 months ago (2016-06-29 15:56:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 17:19:12 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:19:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b37b2e3abbe6eee8bad666bd543b23570f3ca7c2 Cr-Commit-Position: refs/heads/master@{#402847}
4 years, 5 months ago (2016-06-29 17:23:24 UTC) #10
agl
4 years, 5 months ago (2016-06-29 17:33:51 UTC) #11
Message was sent while issue was closed.
LGTM for zlib changes.

Powered by Google App Engine
This is Rietveld 408576698