Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2107163002: Reland of [turbofan] Implicitly emit eager checkpoint at graph building. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-graph-builder-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #1 id:1 of https://codereview.chromium.org/2104973004/ ) Reason for revert: Can be cleanly relanded without any changes after a fix to redundancy elimination. Kudos go to Benedikt. Depends on: https://codereview.chromium.org/2112463002/ Original issue's description: > Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) > > Reason for revert: > Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: > > # > # Fatal error in Zone > # Allocation failed - process out of memory > # > > Original issue's description: > > [turbofan] Implicitly emit eager checkpoint at graph building. > > > > This makes preparation of eager checkpoints within the graph builder > > implicit. Every sub-expression visitation is now guaranteed to emit > > valid checkpoints in AstContext. > > > > R=jarin@chromium.org > > BUG=v8:5021 > > > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > > Cr-Commit-Position: refs/heads/master@{#37368} > > TBR=jarin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5021 > > Committed: https://crrev.com/45190a4fbfa5199f6ddf5ed9a7e2f50be865e0db > Cr-Commit-Position: refs/heads/master@{#37372} TBR=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/36c635131fbddd8fac1128cf08948bb4ba837dba Cr-Commit-Position: refs/heads/master@{#37395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -126 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 58 chunks +105 lines, -121 lines 0 comments Download
M src/compiler/checkpoint-elimination.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/checkpoint-elimination.cc View 1 chunk +27 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Michael Starzinger
Created Reland of [turbofan] Implicitly emit eager checkpoint at graph building.
4 years, 5 months ago (2016-06-29 11:47:32 UTC) #1
Michael Starzinger
4 years, 5 months ago (2016-06-29 11:48:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107163002/1
4 years, 5 months ago (2016-06-29 12:19:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 12:19:26 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107163002/1
4 years, 5 months ago (2016-06-29 12:20:32 UTC) #10
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-29 12:41:06 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 12:48:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107163002/1
4 years, 5 months ago (2016-06-29 12:48:59 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 12:54:04 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 12:54:42 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36c635131fbddd8fac1128cf08948bb4ba837dba
Cr-Commit-Position: refs/heads/master@{#37395}

Powered by Google App Engine
This is Rietveld 408576698