third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp - Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename the method in TreeScope class Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGMPathElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGTreeScopeResources.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

index 1e790eb56971fe51959c182e1a845a5b4d39f45c..82efc36e30c4a41420630072c327150348d228b1 100644

--- a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

@@ -124,11 +124,11 @@ void SVGTextPathElement::buildPendingResource()

Element* target = SVGURIReference::targetElementFromIRIString(hrefString(), treeScope(), &id);

if (!target) {

// Do not register as pending if we are already pending this resource.

- if (document().accessSVGExtensions().isElementPendingResource(this, id))

+ if (treeScope().accessSVGTreeScopedResources().isElementPendingResource(this, id))

return;

if (!id.isEmpty()) {

- document().accessSVGExtensions().addPendingResource(id, this);

+ treeScope().accessSVGTreeScopedResources().addPendingResource(id, this);

ASSERT(hasPendingResources());

}

} else if (isSVGPathElement(*target)) {