Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename the method in TreeScope class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
diff --git a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
index a825a447ac096c4f4551391d614ad6575477191b..21078c8bf3c6e957df52fe9870913aeab1247e2a 100644
--- a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
+++ b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
@@ -51,10 +51,6 @@ public:
// Records the SVG element as having a Web Animation on an SVG attribute that needs applying.
void addWebAnimationsPendingSVGElement(SVGElement&);
- void addResource(const AtomicString& id, LayoutSVGResourceContainer*);
- void removeResource(const AtomicString& id);
- LayoutSVGResourceContainer* resourceById(const AtomicString& id) const;
-
static void serviceOnAnimationFrame(Document&);
void startAnimations();
@@ -85,9 +81,6 @@ private:
HeapHashSet<Member<SVGSVGElement>> m_timeContainers; // For SVG 1.2 support this will need to be made more general.
using SVGElementSet = HeapHashSet<Member<SVGElement>>;
SVGElementSet m_webAnimationsPendingSVGElements;
- HashMap<AtomicString, LayoutSVGResourceContainer*> m_resources;
- HeapHashMap<AtomicString, Member<SVGPendingElements>> m_pendingResources; // Resources that are pending.
- HeapHashMap<AtomicString, Member<SVGPendingElements>> m_pendingResourcesForRemoval; // Resources that are pending and scheduled for removal.
SVGResourcesCache m_resourcesCache;
HeapHashSet<Member<SVGSVGElement>> m_relativeLengthSVGRoots; // Root SVG elements with relative length descendants.
FloatPoint m_translate;
@@ -96,25 +89,7 @@ private:
#endif
public:
- // This HashMap contains a list of pending resources. Pending resources, are such
- // which are referenced by any object in the SVG document, but do NOT exist yet.
- // For instance, dynamically build gradients / patterns / clippers...
- void addPendingResource(const AtomicString& id, Element*);
- bool hasPendingResource(const AtomicString& id) const;
- bool isElementPendingResources(Element*) const;
- bool isElementPendingResource(Element*, const AtomicString& id) const;
- void clearHasPendingResourcesIfPossible(Element*);
- void removeElementFromPendingResources(Element*);
- SVGPendingElements* removePendingResource(const AtomicString& id);
-
void serviceAnimations();
-
- // The following two functions are used for scheduling a pending resource to be removed.
- void markPendingResourcesForRemoval(const AtomicString&);
- Element* removeElementFromPendingResourcesForRemoval(const AtomicString&);
-
-private:
- SVGPendingElements* removePendingResourceForRemoval(const AtomicString&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698