third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h - Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename the method in TreeScope class Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScope.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

index 9b50df2308e3debbe3137e6d333ad4b8509d8256..bd424358a2140ceb63e7a88940596b69bd408f1f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

@@ -114,7 +114,7 @@ inline LayoutSVGResourceContainer* getLayoutSVGResourceContainerById(TreeScope&

if (id.isEmpty())

return nullptr;

- if (LayoutSVGResourceContainer* layoutResource = treeScope.document().accessSVGExtensions().resourceById(id))

+ if (LayoutSVGResourceContainer* layoutResource = treeScope.accessSVGTreeScopedResources().resourceById(id))

return layoutResource;

return nullptr;