third_party/WebKit/Source/core/dom/Element.cpp - Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2107153002: SVG object with same idrefs get conflicted even they are under different shadow root Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/dom/TreeScope.h » ('j') | third_party/WebKit/Source/core/dom/TreeScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 810755bd6138d2740859c6dfeebac5ffb123a164..60d57ef5cd122c08201946f8aee3a09450919612 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1504,7 +1504,7 @@ void Element::removedFrom(ContainerNode* insertionPoint)

document().setCSSTarget(nullptr);

if (hasPendingResources())

- document().accessSVGExtensions().removeElementFromPendingResources(this);

+ treeScope().accessSVGTreeScopedResources().removeElementFromPendingResources(this);

if (getCustomElementState() == CustomElementState::Custom)

CustomElement::enqueueDisconnectedCallback(this);