SVG object with same idrefs get conflicted even they are under different shadow root

third_party/WebKit/Source/core/dom/TreeScope.cpp

 /*
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  * Copyright (C) 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 475 matching lines @@
 void TreeScope::setNeedsStyleRecalcForViewportUnits()
 {
     for (Element* element = ElementTraversal::firstWithin(rootNode()); element; element = ElementTraversal::nextIncludingPseudo(*element)) {
         for (ShadowRoot* root = element->youngestShadowRoot(); root; root = root->olderShadowRoot())
             root->setNeedsStyleRecalcForViewportUnits();
         const ComputedStyle* style = element->computedStyle();
         if (style && style->hasViewportUnits())
             element->setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::ViewportUnits));
     }
 }
+const SVGTreeScopeResources* TreeScope::svgTreeScopedResources()

[hayato, 2016/07/04 04:27:29]

Could we rename this to TreeScope::svgExtensions()?

"TreeScope" in a function name looks redundant to me.

[taijin, 2016/07/05 06:37:14]

Sure, thanks, will do it:)

+    {
+        return m_svgTreeScopedResources.get();
+    }
+
+SVGTreeScopeResources& TreeScope::accessSVGTreeScopedResources()
+{
+    if (!m_svgTreeScopedResources)
+        m_svgTreeScopedResources = new SVGTreeScopeResources(this);
+    return *m_svgTreeScopedResources;
+}
+
 
 DEFINE_TRACE(TreeScope)
 {
     visitor->trace(m_rootNode);
     visitor->trace(m_document);
     visitor->trace(m_parentTreeScope);
     visitor->trace(m_idTargetObserverRegistry);
     visitor->trace(m_selection);
     visitor->trace(m_elementsById);
     visitor->trace(m_imageMapsByName);
     visitor->trace(m_scopedStyleResolver);
     visitor->trace(m_radioButtonGroupScope);
+    visitor->trace(m_svgTreeScopedResources);
 }
 
 } // namespace blink