Make WebAudio output as stereo as default

Source/modules/webaudio/AudioContext.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 392 matching lines @@
         audioTrack = audioTracks[i];
         if (audioTrack->component()->audioSourceProvider()) {
             provider = audioTrack->component()->audioSourceProvider();
             break;
         }
     }
 
     RefPtr<MediaStreamAudioSourceNode> node = MediaStreamAudioSourceNode::create(this, mediaStream, audioTrack.get(), provider);
 
     // FIXME: Only stereo streams are supported right now. We should be able to accept multi-channel streams.
     node->setFormat(2, sampleRate());

[no longer working on chromium, 2014/03/25 10:08:29]

for example here

 
     refNode(node.get()); // context keeps reference until node is disconnected
     return node;
 }
 
 PassRefPtr<MediaStreamAudioDestinationNode> AudioContext::createMediaStreamDestination()
 {
     // FIXME: Add support for an optional argument which specifies the number of channels.

[Tommy Widenflycht, 2014/03/25 09:49:27]

I guess this comment can be removed as well

[no longer working on chromium, 2014/03/25 10:08:29]

Done with replacing the FIXME with a comment, as how it is done in other places.

-    // FIXME: The default should probably be stereo instead of mono.
-    return MediaStreamAudioDestinationNode::create(this, 1);
+    return MediaStreamAudioDestinationNode::create(this, 2);

[Tommy Widenflycht, 2014/03/25 09:49:27]

Can this be made into an enum? MediaStreamAudioDestinationNode::Stereo is much
better than 2.

[no longer working on chromium, 2014/03/25 10:08:29]

:) Looking at the whole file, they use 2 for the channel. I suggest we should
keep what it is, and leave it to WebAudio guys to do a thorough clean-up if they
think it is suitable.

 }
 
 PassRefPtr<ScriptProcessorNode> AudioContext::createScriptProcessor(ExceptionState& exceptionState)
 {
     // Set number of input/output channels to stereo by default.
     return createScriptProcessor(0, 2, 2, exceptionState);

[no longer working on chromium, 2014/03/25 10:08:29]

here, and elsewhere in all the webaudio code.

 }
 
 PassRefPtr<ScriptProcessorNode> AudioContext::createScriptProcessor(size_t bufferSize, ExceptionState& exceptionState)
 {
     // Set number of input/output channels to stereo by default.
     return createScriptProcessor(bufferSize, 2, 2, exceptionState);
 }
 
 PassRefPtr<ScriptProcessorNode> AudioContext::createScriptProcessor(size_t bufferSize, size_t numberOfInputChannels, ExceptionState& exceptionState)
 {
@@ skipping 599 matching lines @@
 }
 
 void AudioContext::decrementActiveSourceCount()
 {
     atomicDecrement(&m_activeSourceCount);
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)