Source/core/css/CSSParserValues.h - Issue 210713002: Implement ::shadow pseudo element and replace /shadow/ with ::shadow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSParserValues.h

Issue 210713002: Implement ::shadow pseudo element and replace /shadow/ with ::shadow. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed patch conflict Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/invalidation/targeted-class-shadow-combinator-expected.txt ('K') | « Source/core/css/CSSGrammar.y ('k') | Source/core/css/CSSSelector.h » ('j') | Source/core/css/CSSSelector.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSParserValues.h

diff --git a/Source/core/css/CSSParserValues.h b/Source/core/css/CSSParserValues.h

index 60adabc0ba899572dc49a3df7933c31e815aec91..a6cbf689fbc807e2f130640ed2aec40c48fd3a6e 100644

--- a/Source/core/css/CSSParserValues.h

+++ b/Source/core/css/CSSParserValues.h

@@ -238,7 +238,7 @@ public:

CSSSelector::PseudoType pseudoType() const { return m_selector->pseudoType(); }

bool isCustomPseudoElement() const { return m_selector->isCustomPseudoElement(); }

- bool needsCrossingTreeScopeBoundary() const { return isCustomPseudoElement() || pseudoType() == CSSSelector::PseudoCue; }

+ bool needsCrossingTreeScopeBoundary() const { return isCustomPseudoElement() || pseudoType() == CSSSelector::PseudoCue || pseudoType() == CSSSelector::PseudoShadow; }

dglazkov 2014/03/25 17:10:53 This function could lose "needs" and "boundary" an

tasak 2014/03/26 11:01:46 Done.

bool isSimple() const;

bool hasShadowPseudo() const;