third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp - Issue 2107103002: Find cached display items directly during painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

Issue 2107103002: Find cached display items directly during painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address pdr's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | third_party/WebKit/Source/platform/graphics/ContiguousContainer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

index c0eb0e53b90b99020ea44b39526b2500a82b8ce2..abc9a5abb68e0088009b16f447c51be5f8196b45 100644

--- a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp

@@ -76,9 +76,7 @@ TEST_F(LayoutObjectDrawingRecorderTest, Cached)

drawNothing(context, layoutView(), PaintPhaseSelfBlockBackgroundOnly, bound);

drawRect(context, layoutView(), PaintPhaseForeground, bound);

- EXPECT_DISPLAY_LIST(rootPaintController().newDisplayItemList(), 2,

- TestDisplayItem(layoutView(), DisplayItem::drawingTypeToCachedDrawingType(DisplayItem::paintPhaseToDrawingType(PaintPhaseSelfBlockBackgroundOnly))),

- TestDisplayItem(layoutView(), DisplayItem::drawingTypeToCachedDrawingType(DisplayItem::paintPhaseToDrawingType(PaintPhaseForeground))));

+ EXPECT_EQ(2, numCachedNewItems());

rootPaintController().commitNewDisplayItems();