Convert some methods to std::lower_bound and std::find_if.

Convert some methods to std::lower_bound and std::find_if.

This CL updates XFA_GetElementTypeForName() to use std::lower_bound instead of
a custom binary search implementation to find the element info.

XFA_GetPropertyOfElement() is changed to use std::find_if. Previously it was
using a custom binary search implementation. Changing this to non-binary search
will allow having the items in g_XFAElementPropertyData be out of XFA_Element
order. There are at most 19 items that need to be searched and often 1 or 2.

Committed: https://pdfium.googlesource.com/pdfium/+/d5fd8e4aa5041b2402b703d824d8736bd5407231

[dsinclair, 2016-06-30 03:24:08]

Patchset #2 (id:20001) has been deleted

[dsinclair, 2016-06-30 03:40:15]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-06-30 03:40:16]

https://codereview.chromium.org/2107093004/diff/1/xfa/fxfa/parser/xfa_basic_i...
File xfa/fxfa/parser/xfa_basic_imp.cpp (right):

https://codereview.chromium.org/2107093004/diff/1/xfa/fxfa/parser/xfa_basic_i...
xfa/fxfa/parser/xfa_basic_imp.cpp:246: auto it = std::find_if(pProperties,
pProperties + iCount,
I'm looking into generating some of these tables. Not having to have this data
in a specific sort order will make that a lot simpler. The number of items
search is small, so I think this shouldn't be a performance issue.

[dsinclair, 2016-06-30 03:40:32]

Description was changed from

==========
Convert xfa basic data methods to std::lower_bound and std::find_if.

This CL updates XFA_GetElementTypeForName() to use std::lower_bound instead of
a custom binary search implementation to find the element info.

XFA_GetPropertyOfElement() is changed to use std::find_if. Previously it was
using a custom binary search implementation. Changing this to non-binary search
will allow having the items in g_XFAElementPropertyData be out of XFA_Element
order. There are at most 19 items that need to be searched and often 1 or 2.
==========

to

==========
Convert some methods to std::lower_bound and std::find_if.

This CL updates XFA_GetElementTypeForName() to use std::lower_bound instead of
a custom binary search implementation to find the element info.

XFA_GetPropertyOfElement() is changed to use std::find_if. Previously it was
using a custom binary search implementation. Changing this to non-binary search
will allow having the items in g_XFAElementPropertyData be out of XFA_Element
order. There are at most 19 items that need to be searched and often 1 or 2.
==========

[Lei Zhang, 2016-06-30 22:41:48]

lgtm

[Lei Zhang, 2016-07-01 02:55:05]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-07-01 02:55:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 02:55:42]

Description was changed from

==========
Convert some methods to std::lower_bound and std::find_if.

This CL updates XFA_GetElementTypeForName() to use std::lower_bound instead of
a custom binary search implementation to find the element info.

XFA_GetPropertyOfElement() is changed to use std::find_if. Previously it was
using a custom binary search implementation. Changing this to non-binary search
will allow having the items in g_XFAElementPropertyData be out of XFA_Element
order. There are at most 19 items that need to be searched and often 1 or 2.
==========

to

==========
Convert some methods to std::lower_bound and std::find_if.

This CL updates XFA_GetElementTypeForName() to use std::lower_bound instead of
a custom binary search implementation to find the element info.

XFA_GetPropertyOfElement() is changed to use std::find_if. Previously it was
using a custom binary search implementation. Changing this to non-binary search
will allow having the items in g_XFAElementPropertyData be out of XFA_Element
order. There are at most 19 items that need to be searched and often 1 or 2.

Committed:
https://pdfium.googlesource.com/pdfium/+/d5fd8e4aa5041b2402b703d824d8736bd540...
==========

[commit-bot: I haz the power, 2016-07-01 02:55:43]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d5fd8e4aa5041b2402b703d824d8736bd540...