Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2107093002: Revert of Add Edit/Create Address Dialog to MD Settings. (Closed)

Created:
4 years, 5 months ago by shans
Modified:
4 years, 5 months ago
Reviewers:
michaelpg, hcarmona
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-polymer_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Edit/Create Address Dialog to MD Settings. (patchset #7 id:140001 of https://codereview.chromium.org/2079853002/ ) Reason for revert: New tests are failing on https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/55180 Original issue's description: > Add Edit/Create Address Dialog to MD Settings. > > Change includes lots of tests. > > Screenshots of dialog in bug. > > BUG=607347 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/7b42531c9e81e485dadc15ee7320134c9aac202a > Cr-Commit-Position: refs/heads/master@{#402580} TBR=michaelpg@chromium.org,hcarmona@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607347 Committed: https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a Cr-Commit-Position: refs/heads/master@{#402731}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
shans
Created Revert of Add Edit/Create Address Dialog to MD Settings.
4 years, 5 months ago (2016-06-29 05:10:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107093002/1
4 years, 5 months ago (2016-06-29 05:11:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 05:14:14 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:16:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad47f31ee89c9eb0ed7a94054e5c8464e8c77c9a
Cr-Commit-Position: refs/heads/master@{#402731}

Powered by Google App Engine
This is Rietveld 408576698