|
|
Created:
4 years, 5 months ago by The one and only Dr. Crash Modified:
4 years, 5 months ago CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkalin1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded flag for enterprise zero-touch enrollment and force enrollment if
its value is the string forced.
BUG=624187
,b/29833682
Committed: https://crrev.com/00baf53974d4fb52f6a0e35a6bb460603b83fa84
Cr-Commit-Position: refs/heads/master@{#403278}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed review comments. #
Messages
Total messages: 28 (16 generated)
Description was changed from ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG= ========== to ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG= ==========
drcrash@chromium.org changed reviewers: + pastarmovj@chromium.org
drcrash@chromium.org changed reviewers: + stevenjb@chromium.org
Description was changed from ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG= ========== to ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=b/29833682 ==========
The CQ bit was checked by drcrash@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=b/29833682 ========== to ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187,b/29833682 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with two small nits. https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:338: const char kZeroTouchEnrollmentForced[] = "forced"; nit: Can you move this to the top of the file please. https://codereview.chromium.org/2107033002/diff/1/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/2107033002/diff/1/chromeos/chromeos_switches.... chromeos/chromeos_switches.cc:204: // The presence of this flag enables the zero-touch enterprise enrollment nit: Why not simply "Enables zero-touch enterprise enrollment flow."
https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/pol... File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/pol... chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:338: const char kZeroTouchEnrollmentForced[] = "forced"; On 2016/06/29 08:46:01, pastarmovj wrote: > nit: Can you move this to the top of the file please. Done. https://codereview.chromium.org/2107033002/diff/1/chromeos/chromeos_switches.cc File chromeos/chromeos_switches.cc (right): https://codereview.chromium.org/2107033002/diff/1/chromeos/chromeos_switches.... chromeos/chromeos_switches.cc:204: // The presence of this flag enables the zero-touch enterprise enrollment On 2016/06/29 08:46:02, pastarmovj wrote: > nit: Why not simply "Enables zero-touch enterprise enrollment flow." Done.
lgtm
The CQ bit was checked by drcrash@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pastarmovj@chromium.org Link to the patchset: https://codereview.chromium.org/2107033002/#ps20001 (title: "Addressed review comments.")
The CQ bit was unchecked by drcrash@chromium.org
The CQ bit was checked by drcrash@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pastarmovj@chromium.org Link to the patchset: https://codereview.chromium.org/2107033002/#ps20001 (title: "Addressed review comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by drcrash@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187,b/29833682 ========== to ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187,b/29833682 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187,b/29833682 ========== to ========== Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187,b/29833682 Committed: https://crrev.com/00baf53974d4fb52f6a0e35a6bb460603b83fa84 Cr-Commit-Position: refs/heads/master@{#403278} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/00baf53974d4fb52f6a0e35a6bb460603b83fa84 Cr-Commit-Position: refs/heads/master@{#403278} |