Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2107033002: Added flag for enterprise zero-touch enrollment and force enrollment if (Closed)

Created:
4 years, 5 months ago by The one and only Dr. Crash
Modified:
4 years, 5 months ago
Reviewers:
stevenjb, pastarmovj
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org, dkalin1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added flag for enterprise zero-touch enrollment and force enrollment if its value is the string forced. BUG=624187 ,b/29833682 Committed: https://crrev.com/00baf53974d4fb52f6a0e35a6bb460603b83fa84 Cr-Commit-Position: refs/heads/master@{#403278}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 5 chunks +22 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
The one and only Dr. Crash
4 years, 5 months ago (2016-06-28 23:18:26 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107033002/1
4 years, 5 months ago (2016-06-28 23:33:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 01:19:48 UTC) #10
pastarmovj
lgtm with two small nits. https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc#newcode338 chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:338: const char kZeroTouchEnrollmentForced[] = ...
4 years, 5 months ago (2016-06-29 08:46:02 UTC) #11
The one and only Dr. Crash
https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc File chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc (right): https://codereview.chromium.org/2107033002/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc#newcode338 chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc:338: const char kZeroTouchEnrollmentForced[] = "forced"; On 2016/06/29 08:46:01, pastarmovj ...
4 years, 5 months ago (2016-06-29 21:04:38 UTC) #12
stevenjb
lgtm
4 years, 5 months ago (2016-06-29 23:47:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107033002/20001
4 years, 5 months ago (2016-06-30 00:17:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/194456)
4 years, 5 months ago (2016-06-30 01:08:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107033002/20001
4 years, 5 months ago (2016-06-30 20:29:48 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 20:53:03 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:53:12 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:55:02 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00baf53974d4fb52f6a0e35a6bb460603b83fa84
Cr-Commit-Position: refs/heads/master@{#403278}

Powered by Google App Engine
This is Rietveld 408576698