Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: ui/views/accessibility/native_view_accessibility.cc

Issue 2106953005: Mac: Add new accessibility attributes for textfields (and some for all views). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ax-attrs
Patch Set: Address review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/accessibility/native_view_accessibility.cc
diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc
index ab86be128e34ba269b12e339be1725abae1e4016..0cdec0d150397aec2813046df89fb1e840bc32c4 100644
--- a/ui/views/accessibility/native_view_accessibility.cc
+++ b/ui/views/accessibility/native_view_accessibility.cc
@@ -63,6 +63,8 @@ const ui::AXNodeData& NativeViewAccessibility::GetData() {
base::UTF16ToUTF8(state.default_action));
data_.AddStringAttribute(ui::AX_ATTR_SHORTCUT,
base::UTF16ToUTF8(state.keyboard_shortcut));
+ data_.AddStringAttribute(ui::AX_ATTR_PLACEHOLDER,
+ base::UTF16ToUTF8(state.placeholder));
data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, state.selection_start);
data_.AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, state.selection_end);
« no previous file with comments | « ui/accessibility/platform/ax_platform_node_mac.mm ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698