Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2106933003: Revert of [heap] Reland uncommit unused large object page memory. (Closed)

Created:
4 years, 5 months ago by Hannes Payer (out of office)
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Reland uncommit unused large object page memory. (patchset #1 id:1 of https://codereview.chromium.org/2101383002/ ) Reason for revert: Crashes unbox-double-arrays Original issue's description: > [heap] Reland uncommit unused large object page memory. > > BUG= > > Committed: https://crrev.com/dd0ee5fd11653ba41a292641ccd66ae7cc5a8398 > Cr-Commit-Position: refs/heads/master@{#37341} TBR=ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f99f633309e4f352a2bbf40ce15f06834cd80439 Cr-Commit-Position: refs/heads/master@{#37347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -205 lines) Patch
M src/base/hashmap.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/base/platform/platform.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/base/platform/platform-linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/base/platform/platform-macos.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +1 line, -13 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +21 lines, -87 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D test/mjsunit/regress/regress-617882.js View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Hannes Payer (out of office)
Created Revert of [heap] Reland uncommit unused large object page memory.
4 years, 5 months ago (2016-06-28 20:20:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106933003/1
4 years, 5 months ago (2016-06-28 20:20:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 20:20:54 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:22:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f99f633309e4f352a2bbf40ce15f06834cd80439
Cr-Commit-Position: refs/heads/master@{#37347}

Powered by Google App Engine
This is Rietveld 408576698