Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: test/cctest/test-assembler-ia32.cc

Issue 2106913002: Revert of [ia32] Fixes a bug in cmpw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/disasm-ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-assembler-ia32.cc
diff --git a/test/cctest/test-assembler-ia32.cc b/test/cctest/test-assembler-ia32.cc
index 0557715bedceed42a3fc13717ce36a2b1bafad6e..12733c2cdda3ddf7296f71739c2334ed83df351a 100644
--- a/test/cctest/test-assembler-ia32.cc
+++ b/test/cctest/test-assembler-ia32.cc
@@ -1497,37 +1497,4 @@
}
}
-TEST(Regress621926) {
- // Bug description:
- // The opcodes for cmpw r/m16, r16 and cmpw r16, r/m16 were swapped.
- // This was causing non-commutative comparisons to produce the wrong result.
- CcTest::InitializeVM();
- Isolate* isolate = reinterpret_cast<Isolate*>(CcTest::isolate());
- HandleScope scope(isolate);
- Assembler assm(isolate, nullptr, 0);
-
- int16_t a = 42;
-
- Label fail;
- __ mov(ebx, Immediate(reinterpret_cast<intptr_t>(&a)));
- __ mov(eax, Immediate(41));
- __ cmpw(eax, Operand(ebx));
- __ j(above_equal, &fail);
- __ cmpw(Operand(ebx), eax);
- __ j(below_equal, &fail);
- __ mov(eax, 1);
- __ ret(0);
- __ bind(&fail);
- __ mov(eax, 0);
- __ ret(0);
-
- CodeDesc desc;
- assm.GetCode(&desc);
- Handle<Code> code = isolate->factory()->NewCode(
- desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
-
- F0 f = FUNCTION_CAST<F0>(code->entry());
- CHECK_EQ(f(), 1);
-}
-
#undef __
« no previous file with comments | « src/ia32/disasm-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698