Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2106913002: Revert of [ia32] Fixes a bug in cmpw. (Closed)

Created:
4 years, 5 months ago by epertoso
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ia32] Fixes a bug in cmpw. (patchset #3 id:40001 of https://codereview.chromium.org/2103713003/ ) Reason for revert: Causes "buildbot failure in V8 on V8 Linux gcc 4.8, Check" Original issue's description: > [ia32] Fixes a bug in cmpw. > > The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. > > Adds a regression test. > > BUG=621926 > > Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 > Cr-Commit-Position: refs/heads/master@{#37339} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621926 Committed: https://crrev.com/bcdd03159015fd6a24140b1cfc97c3ef3de50b69 Cr-Commit-Position: refs/heads/master@{#37342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -57 lines) Patch
M src/ia32/assembler-ia32.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +4 lines, -17 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
epertoso
Created Revert of [ia32] Fixes a bug in cmpw.
4 years, 5 months ago (2016-06-28 17:42:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106913002/1
4 years, 5 months ago (2016-06-28 17:42:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 17:42:53 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 17:44:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcdd03159015fd6a24140b1cfc97c3ef3de50b69
Cr-Commit-Position: refs/heads/master@{#37342}

Powered by Google App Engine
This is Rietveld 408576698