|
|
DescriptionRemove Mac10.11 specifiers from TestExpectations as an experiment.
Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed.
Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted.
BUG=624020
Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a
Cr-Commit-Position: refs/heads/master@{#406134}
Patch Set 1 #
Messages
Total messages: 18 (6 generated)
Description was changed from ========== Remove Mac10.11 specifiers from TestExpectations as an experiment. BUG=624020 ========== to ========== Remove Mac10.11 specifiers from TestExpectations as an experiment. Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. BUG=624020 ==========
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org, wkorman@chromium.org
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/07 at 20:13:11, commit-bot wrote: > Dry run: This issue passed the CQ dry run. Following up with this CL: does this seem like it makes sense? Would it be OK to try submitting this?
On 2016/07/18 at 18:33:09, qyearsley wrote: > On 2016/07/07 at 20:13:11, commit-bot wrote: > > Dry run: This issue passed the CQ dry run. > > Following up with this CL: does this seem like it makes sense? Would it be OK to try submitting this? OK with me -- I lost track of where we ended up with your reworking the involved specifiers, but seeing what happens with this would provide a data point.
lgtm
On 2016/07/18 at 19:43:35, wkorman wrote: > On 2016/07/18 at 18:33:09, qyearsley wrote: > > On 2016/07/07 at 20:13:11, commit-bot wrote: > > > Dry run: This issue passed the CQ dry run. > > > > Following up with this CL: does this seem like it makes sense? Would it be OK to try submitting this? > > OK with me -- I lost track of where we ended up with your reworking the involved specifiers, but seeing what happens with this would provide a data point. Nothing was committed so far involving renaming things, but we discovered that at least in the official list of builders, 10.11 is used instead of Mac10.11, and I can't see anything else linking the builder "WebKit Mac10.11" to the specifier "Mac10.11", so it seems like this might be able to be committed without breaking things, and if that is true, then that's good news since it simplifies the TestExpectations file a little.
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove Mac10.11 specifiers from TestExpectations as an experiment. Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. BUG=624020 ========== to ========== Remove Mac10.11 specifiers from TestExpectations as an experiment. Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. BUG=624020 Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a Cr-Commit-Position: refs/heads/master@{#406134} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a Cr-Commit-Position: refs/heads/master@{#406134}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2160113003/ by qyearsley@chromium.org. The reason for reverting is: After this was committed, the webkit_tests on the waterfall went red (example build https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...) This means that these lines in TestExpectations are *not* without effect.. |