Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Issue 2106903002: Remove Mac10.11 specifiers from TestExpectations as an experiment. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Mac10.11 specifiers from TestExpectations as an experiment. Due to bug 624020, it seems possible that the Mac10.11 specifiers in TestExpectations have been ignored by the WebKit Mac 10.11 builder; if this is the case, then those specifiers in TestExpectations should have no effect and could theoretically be removed. Submitting this CL might cause WebKit Mac 10.11 to fail, and if that happens, then this should be reverted. BUG=624020 Committed: https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a Cr-Commit-Position: refs/heads/master@{#406134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
qyearsley
4 years, 5 months ago (2016-06-28 17:41:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106903002/1
4 years, 5 months ago (2016-07-07 18:40:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 20:13:11 UTC) #7
qyearsley
On 2016/07/07 at 20:13:11, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 5 months ago (2016-07-18 18:33:09 UTC) #8
wkorman
On 2016/07/18 at 18:33:09, qyearsley wrote: > On 2016/07/07 at 20:13:11, commit-bot wrote: > > ...
4 years, 5 months ago (2016-07-18 19:43:35 UTC) #9
wkorman
lgtm
4 years, 5 months ago (2016-07-18 19:43:39 UTC) #10
qyearsley
On 2016/07/18 at 19:43:35, wkorman wrote: > On 2016/07/18 at 18:33:09, qyearsley wrote: > > ...
4 years, 5 months ago (2016-07-18 20:42:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106903002/1
4 years, 5 months ago (2016-07-18 20:42:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:35:13 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:35:35 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/63408fdbcfeaf1bd6fb298afee23ac9563bf218a Cr-Commit-Position: refs/heads/master@{#406134}
4 years, 5 months ago (2016-07-18 23:36:20 UTC) #17
qyearsley
4 years, 5 months ago (2016-07-19 00:33:25 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2160113003/ by qyearsley@chromium.org.

The reason for reverting is: After this was committed, the webkit_tests on the
waterfall went red (example build
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...)

This means that these lines in TestExpectations are *not* without effect..

Powered by Google App Engine
This is Rietveld 408576698