Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2106893003: Fixed crash when RunInSeriesFP's color input is nil (Closed)

Created:
4 years, 5 months ago by dvonbeck
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixed crash when RunInSeriesFP's color input is nil SeriesFragmentProcessor would call emitChild with "" input color as opposed to nil input color when ginven a nil input color. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2106893003 Committed: https://skia.googlesource.com/skia/+/ca9eeab0eaa32fc8f61be9003fafc3fe1afe78e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/gpu/GrFragmentProcessor.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dvonbeck
4 years, 5 months ago (2016-06-28 18:56:27 UTC) #4
robertphillips
What's the status of this ?
4 years, 5 months ago (2016-07-06 15:31:20 UTC) #6
dvonbeck
On 2016/07/06 15:31:20, robertphillips wrote: > What's the status of this ? It works on ...
4 years, 5 months ago (2016-07-06 15:45:43 UTC) #7
robertphillips
lgtm
4 years, 5 months ago (2016-07-06 16:47:12 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106893003/1
4 years, 5 months ago (2016-07-06 16:47:25 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 17:21:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106893003/1
4 years, 5 months ago (2016-07-06 17:32:42 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 19:00:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca9eeab0eaa32fc8f61be9003fafc3fe1afe78e4

Powered by Google App Engine
This is Rietveld 408576698