Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2106883002: PPC/s390: [turbofan] Introduce Float64Pow and NumberPow operators. (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Introduce Float64Pow and NumberPow operators. Port e607e12ea0a706a0b8cb109e95f923426094dc09 Original commit message: Introduce a new machine operator Float64Pow that for now is backed by the existing MathPowStub to start the unification of Math.pow, and at the same time address the main performance issue that TurboFan still has with the imaging-darkroom benchmark in Kraken. Also migrate the Math.pow builtin itself to a TurboFan builtin and remove a few hundred lines of hand-written platform code for special handling of the fullcodegen Math.pow version. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:3599, v8:5086, v8:5157 LOG=N Committed: https://crrev.com/05638b9d1d70ae55c1c7ac934a5f511095dc866d Cr-Commit-Position: refs/heads/master@{#37344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -222 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +15 lines, -110 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 4 chunks +13 lines, -112 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-28 17:27:25 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-06-28 17:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106883002/1
4 years, 5 months ago (2016-06-28 17:31:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 17:58:34 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:01:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05638b9d1d70ae55c1c7ac934a5f511095dc866d
Cr-Commit-Position: refs/heads/master@{#37344}

Powered by Google App Engine
This is Rietveld 408576698