Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2106863005: CT in DevTools: use "Source" rather than "Origin". (Closed)

Created:
4 years, 5 months ago by lgarron
Modified:
4 years, 5 months ago
Reviewers:
dwaxweiler, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org, estark
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CT in DevTools: use "Source" rather than "Origin". BUG=591848 Committed: https://crrev.com/fd0c0c47ff748ddc214e69da33646402bd2f961f Cr-Commit-Position: refs/heads/master@{#403127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
lgarron
dgozman@, could you review? This brings the terminology in line with the new CT details.
4 years, 5 months ago (2016-06-30 00:29:11 UTC) #2
dgozman
lgtm
4 years, 5 months ago (2016-06-30 00:48:42 UTC) #3
lgarron
Daniel, are you alright with this?
4 years, 5 months ago (2016-06-30 02:31:56 UTC) #5
dwaxweiler
On 2016/06/30 02:31:56, lgarron wrote: > Daniel, are you alright with this? Yes, I am ...
4 years, 5 months ago (2016-06-30 07:22:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106863005/1
4 years, 5 months ago (2016-06-30 07:44:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 09:11:26 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 09:12:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd0c0c47ff748ddc214e69da33646402bd2f961f
Cr-Commit-Position: refs/heads/master@{#403127}

Powered by Google App Engine
This is Rietveld 408576698