third_party/WebKit/Source/platform/heap/MarkingVisitor.h - Issue 2106863003: Handle cross-thread weak persistents during global weak processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitor.h

Issue 2106863003: Handle cross-thread weak persistents during global weak processing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: only treat cross-thread weaks during global weak processing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/MarkingVisitor.h

diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h b/third_party/WebKit/Source/platform/heap/MarkingVisitor.h

index 02c96e43c6d07f311fbab78889893614ec3a9cf9..14615fb230cad4cd3209753d4a13a47f985ded29 100644

--- a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h

+++ b/third_party/WebKit/Source/platform/heap/MarkingVisitor.h

@@ -57,12 +57,12 @@ public:

return Impl::ensureMarked(objectPointer);

}

-protected:

void registerWeakCellWithCallback(void** cell, WeakCallback callback) override

{

Impl::registerWeakCellWithCallback(cell, callback);

}

+protected:

inline bool shouldMarkObject(const void* objectPointer) const

{

if (Mode != ThreadLocalMarking)

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h » ('j') | third_party/WebKit/Source/platform/heap/Persistent.h » ('J')