Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2106843003: Blimp engine Dockerfile now depends on Dockerfile.base. (Closed)

Created:
4 years, 5 months ago by Jess
Modified:
4 years, 5 months ago
Reviewers:
Sriram, maniscalco, Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blimp engine Dockerfile now depends on Dockerfile.base. Updating to have engine make use of Dockerfile.base now that the downstream dependencies have had some testing. Docker build dependency verified locally. BUG=616945 Committed: https://crrev.com/1d3e39cae5b3fd3ccd2899b64d1af18eccaf2961 Cr-Commit-Position: refs/heads/master@{#402964}

Patch Set 1 #

Patch Set 2 : Update documentation on docker build for engine to include building the base. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M blimp/docs/container.md View 1 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/Dockerfile View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jess
Follow up on https://codereview.chromium.org/2043403004
4 years, 5 months ago (2016-06-28 23:05:04 UTC) #2
Kevin M
This just looks like magic to me, but... lgtm
4 years, 5 months ago (2016-06-29 17:58:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106843003/20001
4 years, 5 months ago (2016-06-29 21:21:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:37:26 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 22:37:56 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:39:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d3e39cae5b3fd3ccd2899b64d1af18eccaf2961
Cr-Commit-Position: refs/heads/master@{#402964}

Powered by Google App Engine
This is Rietveld 408576698