Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ccd5fbaca5867773830b38ea64c2a79f932f6478
Cr-Commit-Position: refs/heads/master@{#402582}

[erikchen, 2016-06-28 16:06:47]

Description was changed from

==========
Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
==========

to

==========
Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-28 16:07:20]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-06-28 16:07:21]

piman: Please review.

[erikchen, 2016-06-28 16:07:24]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 16:08:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-06-28 17:28:36]

https://codereview.chromium.org/2106843002/diff/1/gpu/ipc/service/image_trans...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2106843002/diff/1/gpu/ipc/service/image_trans...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:352: }
else return false? Or is it ok/meaningful to call ScheduleCALayer with a null
io_surface/cv_pixel_buffer?

[erikchen, 2016-06-28 17:36:08]

https://codereview.chromium.org/2106843002/diff/1/gpu/ipc/service/image_trans...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2106843002/diff/1/gpu/ipc/service/image_trans...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:352: }
On 2016/06/28 17:28:35, piman wrote:
> else return false? Or is it ok/meaningful to call ScheduleCALayer with a null
> io_surface/cv_pixel_buffer?

Good point. We should return false.

[erikchen, 2016-06-28 17:36:12]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 17:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-06-28 18:12:58]

LGTM, and thanks!

[commit-bot: I haz the power, 2016-06-28 18:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 18:22:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2016-06-28 18:55:44]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-28 18:56:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:24:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[erikchen, 2016-06-28 19:33:32]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:35:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 19:51:22]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[erikchen, 2016-06-28 20:30:42]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:32:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 20:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 20:59:20]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[erikchen, 2016-06-28 21:02:02]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-28 21:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 22:50:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 22:53:46]

Description was changed from

==========
Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/ccd5fbaca5867773830b38ea64c2a79f932f6478
Cr-Commit-Position: refs/heads/master@{#402582}
==========

[commit-bot: I haz the power, 2016-06-28 22:53:47]

Patchset 2 (id:??) landed as
https://crrev.com/ccd5fbaca5867773830b38ea64c2a79f932f6478
Cr-Commit-Position: refs/heads/master@{#402582}

[pdr., 2016-06-30 00:04:21]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2104393003/ by pdr@chromium.org.

The reason for reverting is: Broke 3d transforms, see: https://crbug.com/624256.

[ccameron, 2016-06-30 02:48:34]

ccameron@chromium.org changed reviewers:
+ ccameron@chromium.org

[ccameron, 2016-06-30 02:48:35]

https://codereview.chromium.org/2106843002/diff/20001/gpu/ipc/service/image_t...
File gpu/ipc/service/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/2106843002/diff/20001/gpu/ipc/service/image_t...
gpu/ipc/service/image_transport_surface_overlay_mac.mm:348: return false;
|io_surface_image| will be null for solid color layers. We should also issue an
error message when this happens.