Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 210683003: Reland "No longer OOM on invalid string length." (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Reland "No longer OOM on invalid string length." R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20225

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -54 lines) Patch
M src/api.cc View 4 chunks +16 lines, -6 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +9 lines, -1 line 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/factory.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/heap.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/heap-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/json-parser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/json-stringifier.h View 6 chunks +5 lines, -1 line 0 comments Download
M src/jsregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/liveedit.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 13 chunks +29 lines, -21 lines 0 comments Download
M src/uri.h View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M test/mjsunit/string-oom-replace-global-regexp-with-string.js View 1 chunk +14 lines, -2 lines 0 comments Download
M tools/lexer-shell.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Patch set 2 is the fix.
6 years, 9 months ago (2014-03-25 06:58:06 UTC) #1
Igor Sheludko
lgtm
6 years, 9 months ago (2014-03-25 08:16:36 UTC) #2
Yang
6 years, 9 months ago (2014-03-25 09:09:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20225 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698