Refactors maximize mode event handling into its own class

Refactors maximize mode event handling into its own class

This way we can have mash and ash implementations. I can't implement
this in terms of PointerWatcher as it needs to stop propagation.

BUG=624157, 612629
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665
Cr-Commit-Position: refs/heads/master@{#402706}

[James Cook, 2016-06-28 23:10:21]

LGTM

https://codereview.chromium.org/2106823004/diff/20001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right):

https://codereview.chromium.org/2106823004/diff/20001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:20: const int
kLeaveFullScreenAreaHeightInPixel = 2;
Aside: This seems like a weird feature. A 2-pixel tap target is awfully small.
Strange.

[sky, 2016-06-28 23:11:39]

I had the same reaction!

On Tue, Jun 28, 2016 at 4:10 PM,  <jamescook@chromium.org> wrote:
> LGTM
>
>
>
>
https://codereview.chromium.org/2106823004/diff/20001/ash/common/wm/maximize_...
> File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right):
>
>
https://codereview.chromium.org/2106823004/diff/20001/ash/common/wm/maximize_...
> ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:20: const int
> kLeaveFullScreenAreaHeightInPixel = 2;
> Aside: This seems like a weird feature. A 2-pixel tap target is awfully
> small. Strange.
>
> https://codereview.chromium.org/2106823004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2016-06-28 23:11:49]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:13:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 00:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 00:06:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-06-29 03:19:10]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-06-29 03:19:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 03:56:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 03:59:02]

Description was changed from

==========
Refactors maximize mode event handling into its own class

This way we can have mash and ash implementations. I can't implement
this in terms of PointerWatcher as it needs to stop propagation.

BUG=624157, 612629
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Refactors maximize mode event handling into its own class

This way we can have mash and ash implementations. I can't implement
this in terms of PointerWatcher as it needs to stop propagation.

BUG=624157, 612629
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665
Cr-Commit-Position: refs/heads/master@{#402706}
==========

[commit-bot: I haz the power, 2016-06-29 03:59:04]

Patchset 2 (id:??) landed as
https://crrev.com/281b34eeff49d0f6bc9b92eef2a8ac707cb5f665
Cr-Commit-Position: refs/heads/master@{#402706}