Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2106813003: Disable flaky virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html (Closed)

Created:
4 years, 5 months ago by Peng
Modified:
4 years, 5 months ago
Reviewers:
danakj, Pete Williamson
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html BUG=624023 Committed: https://crrev.com/1bc08758e4ad17d0097e139ab4ef3df6f7e1b043 Cr-Commit-Position: refs/heads/master@{#402559}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Disable the test globally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Peng
PTAL. Thanks.
4 years, 5 months ago (2016-06-28 19:17:29 UTC) #2
Pete Williamson
https://codereview.chromium.org/2106813003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2106813003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode1365 third_party/WebKit/LayoutTests/TestExpectations:1365: crbug.com/624023 [ Mac10.11 Win7 ] virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html [ Pass Timeout ...
4 years, 5 months ago (2016-06-28 19:27:18 UTC) #3
danakj
LGTM % Pete
4 years, 5 months ago (2016-06-28 19:58:08 UTC) #4
Peng
https://codereview.chromium.org/2106813003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2106813003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode1365 third_party/WebKit/LayoutTests/TestExpectations:1365: crbug.com/624023 [ Mac10.11 Win7 ] virtual/threaded/fast/compositorworker/basic-plumbing-worker-to-main.html [ Pass Timeout ...
4 years, 5 months ago (2016-06-28 20:02:27 UTC) #5
danakj
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=basic-plumbing-worker-to-main.html has Linux, Linux ASAN, Linux Leak, Linux Trusty, Mac 10.11, Mac 10.11 dbg, Mac ...
4 years, 5 months ago (2016-06-28 20:05:21 UTC) #6
Pete Williamson
On 2016/06/28 20:05:21, danakj wrote: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=basic-plumbing-worker-to-main.html > > has Linux, Linux ASAN, Linux Leak, ...
4 years, 5 months ago (2016-06-28 20:20:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106813003/20001
4 years, 5 months ago (2016-06-28 20:24:15 UTC) #10
Pete Williamson
lgtm
4 years, 5 months ago (2016-06-28 20:27:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 21:58:48 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:00:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bc08758e4ad17d0097e139ab4ef3df6f7e1b043
Cr-Commit-Position: refs/heads/master@{#402559}

Powered by Google App Engine
This is Rietveld 408576698