cc/output/compositor_frame_metadata.h - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/compositor_frame_metadata.h

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change to height and ratio Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/compositor_frame_metadata.h

diff --git a/cc/output/compositor_frame_metadata.h b/cc/output/compositor_frame_metadata.h

index c2e13fe6e3fc91b8ec7d64ebfa180376b54143f7..9627d7d6f4dd4a6aaedace9e2c4af788ff1fff35 100644

--- a/cc/output/compositor_frame_metadata.h

+++ b/cc/output/compositor_frame_metadata.h

@@ -49,8 +49,13 @@ class CC_EXPORT CompositorFrameMetadata {

// Used to position the Android location top bar and page content, whose

// precise position is computed by the renderer compositor.

- gfx::Vector2dF location_bar_offset;

- gfx::Vector2dF location_bar_content_translation;

+ gfx::Vector2dF top_controls_height;

aelias_OOO_until_Jul13 2016/07/08 23:46:33 Hmm, I don't see a reasonable interpretation of 2

Ian Wen 2016/08/13 00:05:27 Done.

+ float top_controls_shown_ratio;

+ // Used to position Android bottom bar, whose position is computed by the

+ // renderer compositor.

+ gfx::Vector2dF bottom_controls_height;

+ float bottom_controls_shown_ratio;

// This color is usually obtained from the background color of the <body>

// element. It can be used for filling in gutter areas around the frame when

« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/trees/layer_tree_host.h » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')