content/browser/renderer_host/render_widget_host_view_android.h - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content-offset -> top-controls-shown renaming and respond to bokan's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 93b76fa28b2b8e2f18a1a61f97e3c175df169271..c809150e6ea48ed11ab30a0b4647b96b29cc46ee 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -106,6 +106,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

gfx::Size GetPhysicalBackingSize() const override;

bool DoTopControlsShrinkBlinkSize() const override;

float GetTopControlsHeight() const override;

+ float GetBottomControlsHeight() const override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

void TextInputStateChanged(const TextInputState& params) override;

@@ -351,7 +352,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

cc::SurfaceId surface_id_;

gfx::Size current_surface_size_;

cc::ReturnedResourceArray surface_returned_resources_;

- gfx::Vector2dF location_bar_content_translation_;

+ gfx::Vector2dF top_bar_shown_;

cc::Selection<gfx::SelectionBound> current_viewport_selection_;

// The most recent texture size that was pushed to the texture layer.