content/browser/devtools/protocol/page_handler.cc - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content-offset -> top-controls-shown renaming and respond to bokan's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index d5a9244dc95b4123fe0e2ad4e5d1248ac2ba873a..924c445d34f4a7854d816932b851433d13840a16 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -484,7 +484,7 @@ void PageHandler::ScreencastFrameEncoded(cc::CompositorFrameMetadata metadata,

scoped_refptr<ScreencastFrameMetadata> param_metadata =

ScreencastFrameMetadata::Create()

->set_page_scale_factor(metadata.page_scale_factor)

- ->set_offset_top(metadata.location_bar_content_translation.y())

+ ->set_offset_top(metadata.top_bar_shown.y())

->set_device_width(screen_size_dip.width())

->set_device_height(screen_size_dip.height())

->set_scroll_offset_x(metadata.root_scroll_offset.x())