cc/ipc/struct_traits_unittest.cc - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Unified Diff: cc/ipc/struct_traits_unittest.cc

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content-offset -> top-controls-shown renaming and respond to bokan's comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/input/top_controls_manager.h ('K') | « cc/ipc/compositor_frame_metadata_struct_traits.h ('k') | cc/output/compositor_frame_metadata.h » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/ipc/struct_traits_unittest.cc

diff --git a/cc/ipc/struct_traits_unittest.cc b/cc/ipc/struct_traits_unittest.cc

index 07e8e2b4105a06f8681162534bf1c422d84f63bb..fd828daac06142c0bac6fe9f35de8ef112306073 100644

--- a/cc/ipc/struct_traits_unittest.cc

+++ b/cc/ipc/struct_traits_unittest.cc

@@ -143,8 +143,10 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {

const float max_page_scale_factor = 4.6f;

const bool root_overflow_x_hidden = true;

const bool root_overflow_y_hidden = true;

- const gfx::Vector2dF location_bar_offset(1234.5f, 5432.1f);

- const gfx::Vector2dF location_bar_content_translation(1234.5f, 5432.1f);

+ const gfx::Vector2dF top_bar_translate(1234.5f, 5432.1f);

+ const gfx::Vector2dF top_bar_shown(1234.5f, 5432.1f);

+ const gfx::Vector2dF bottom_bar_translate(1234.5f, 5432.1f);

+ const gfx::Vector2dF bottom_bar_shown(1234.5f, 5432.1f);

const uint32_t root_background_color = 1337;

Selection<gfx::SelectionBound> selection;

selection.start.SetEdge(gfx::PointF(1234.5f, 67891.f),

@@ -176,8 +178,10 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {

input.max_page_scale_factor = max_page_scale_factor;

input.root_overflow_x_hidden = root_overflow_x_hidden;

input.root_overflow_y_hidden = root_overflow_y_hidden;

- input.location_bar_offset = location_bar_offset;

- input.location_bar_content_translation = location_bar_content_translation;

+ input.top_bar_translate = top_bar_translate;

+ input.top_bar_shown = top_bar_shown;

+ input.bottom_bar_translate = bottom_bar_translate;

+ input.bottom_bar_shown = bottom_bar_shown;

input.root_background_color = root_background_color;

input.selection = selection;

input.latency_info = latency_infos;

@@ -196,9 +200,10 @@ TEST_F(StructTraitsTest, CompositorFrameMetadata) {

EXPECT_EQ(max_page_scale_factor, output.max_page_scale_factor);

EXPECT_EQ(root_overflow_x_hidden, output.root_overflow_x_hidden);

EXPECT_EQ(root_overflow_y_hidden, output.root_overflow_y_hidden);

- EXPECT_EQ(location_bar_offset, output.location_bar_offset);

- EXPECT_EQ(location_bar_content_translation,

- output.location_bar_content_translation);

+ EXPECT_EQ(top_bar_translate, output.top_bar_translate);

+ EXPECT_EQ(top_bar_shown, output.top_bar_shown);

+ EXPECT_EQ(bottom_bar_translate, output.bottom_bar_translate);

+ EXPECT_EQ(bottom_bar_shown, output.bottom_bar_shown);

EXPECT_EQ(root_background_color, output.root_background_color);

EXPECT_EQ(selection, output.selection);

EXPECT_EQ(latency_infos.size(), output.latency_info.size());