chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: vector->float in IPC Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/trees/layer_tree_impl.cc ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index 6cb24acce5fe216154c2193b521fc69d5e54f24c..eb18b1750acaf968632f7355ebe0a4a6659d0b8d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -405,9 +405,9 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

}

@Override

- public void onOffsetsForFullscreenChanged(

- float topControlsOffsetY, float contentOffsetY) {

- onOffsetsChanged(topControlsOffsetY, contentOffsetY, isShowingSadTab());

+ public void onTopControlsChanged(float topControlsOffsetY, float topContentOffsetY) {

+ super.onTopControlsChanged(topControlsOffsetY, topContentOffsetY);

+ onOffsetsChanged(topControlsOffsetY, topContentOffsetY, isShowingSadTab());

}

@Override