content/browser/renderer_host/render_widget_host_impl.cc - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/input/top_controls_manager.cc ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index f2f8ace175bbe0b6f985d2273aee64cc0b7bcd27..4af775a7df1c135f6c3959df4cf13243c039a217 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -581,6 +581,7 @@ bool RenderWidgetHostImpl::GetResizeParams(ResizeParams* resize_params) {

resize_params->top_controls_height = view_->GetTopControlsHeight();

resize_params->top_controls_shrink_blink_size =

view_->DoTopControlsShrinkBlinkSize();

+ resize_params->bottom_controls_height = view_->GetBottomControlsHeight();

resize_params->visible_viewport_size = view_->GetVisibleViewportSize();

}

@@ -600,6 +601,8 @@ bool RenderWidgetHostImpl::GetResizeParams(ResizeParams* resize_params) {

resize_params->top_controls_height ||

old_resize_params_->top_controls_shrink_blink_size !=

resize_params->top_controls_shrink_blink_size ||

+ old_resize_params_->bottom_controls_height !=

+ resize_params->bottom_controls_height ||

old_resize_params_->visible_viewport_size !=

resize_params->visible_viewport_size;