cc/output/compositor_frame_metadata.h - Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling

Side by Side Diff: cc/output/compositor_frame_metadata.h

Issue 2106753004: Introduce bottom controls to CC and let it respond to scrolling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adjust documentations Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/ipc/struct_traits_unittest.cc ('k') | cc/trees/layer_tree_host.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_	5 #ifndef CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_

6 #define CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_	6 #define CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <vector>	10 #include <vector>

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 // determine if scrolling/scaling in a particular direction is possible.	42 // determine if scrolling/scaling in a particular direction is possible.

43 gfx::SizeF scrollable_viewport_size;	43 gfx::SizeF scrollable_viewport_size;

44 gfx::SizeF root_layer_size;	44 gfx::SizeF root_layer_size;

45 float min_page_scale_factor;	45 float min_page_scale_factor;

46 float max_page_scale_factor;	46 float max_page_scale_factor;

47 bool root_overflow_x_hidden;	47 bool root_overflow_x_hidden;

48 bool root_overflow_y_hidden;	48 bool root_overflow_y_hidden;

49	49

50 // Used to position the Android location top bar and page content, whose	50 // Used to position the Android location top bar and page content, whose

51 // precise position is computed by the renderer compositor.	51 // precise position is computed by the renderer compositor.

52 gfx::Vector2dF location_bar_offset;	52 gfx::Vector2dF top_bar_translate;
	aelias_OOO_until_Jul13 2016/07/06 22:36:58 I agree we need two values, but how about standard I agree we need two values, but how about standardizing on "height" and "0-to-1 ratio" instead? There's some difficulties with the two-offset representation which led us to move away from it in CC. If "height" is zero, then there is no way to distinguish between "shown" and "hidden". So if you send two messages in sequence, the first one instructing the state to change to "shown", and the second one setting the height to nonzero, the information in the first message is effectively lost. The ratio representation solves this, as well as allowing exact comparisons to 0 and 1 without worrying about possible floating-point errors.
53 gfx::Vector2dF location_bar_content_translation;	53 gfx::Vector2dF top_bar_shown;

	54

	55 // Used to position Android bottom bar, whose position is computed by the

	56 // renderer compositor.

	57 gfx::Vector2dF bottom_bar_translate;

	58 gfx::Vector2dF bottom_bar_shown;

54	59

55 // This color is usually obtained from the background color of the <body>	60 // This color is usually obtained from the background color of the <body>

56 // element. It can be used for filling in gutter areas around the frame when	61 // element. It can be used for filling in gutter areas around the frame when

57 // it's too small to fill the box the parent reserved for it.	62 // it's too small to fill the box the parent reserved for it.

58 SkColor root_background_color;	63 SkColor root_background_color;

59	64

60 // Provides selection region updates relative to the current viewport. If the	65 // Provides selection region updates relative to the current viewport. If the

61 // selection is empty or otherwise unused, the bound types will indicate such.	66 // selection is empty or otherwise unused, the bound types will indicate such.

62 Selection<gfx::SelectionBound> selection;	67 Selection<gfx::SelectionBound> selection;

63	68

64 std::vector<ui::LatencyInfo> latency_info;	69 std::vector<ui::LatencyInfo> latency_info;

65	70

66 // A set of SurfaceSequences that this frame satisfies (always in the same	71 // A set of SurfaceSequences that this frame satisfies (always in the same

67 // namespace as the current Surface).	72 // namespace as the current Surface).

68 std::vector<uint32_t> satisfies_sequences;	73 std::vector<uint32_t> satisfies_sequences;

69	74

70 // This is the set of Surfaces that are referenced by this frame.	75 // This is the set of Surfaces that are referenced by this frame.

71 std::vector<SurfaceId> referenced_surfaces;	76 std::vector<SurfaceId> referenced_surfaces;

72	77

73 private:	78 private:

74 CompositorFrameMetadata(const CompositorFrameMetadata& other);	79 CompositorFrameMetadata(const CompositorFrameMetadata& other);

75 CompositorFrameMetadata operator=(const CompositorFrameMetadata&) = delete;	80 CompositorFrameMetadata operator=(const CompositorFrameMetadata&) = delete;

76 };	81 };

77	82

78 } // namespace cc	83 } // namespace cc

79	84

80 #endif // CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_	85 #endif // CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_

OLD	NEW