Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2106743005: Reduce noise in GC metrics. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reduce noise in GC metrics. This patch changes GC metrics to be global instead of per RAIL stage. For motivation see the linked bug. Thus the following four metrics: - Response-v8-gc-full-mark-compactor_max - Animation-v8-gc-full-mark-compactor_max - Idle-v8-gc-full-mark-compactor_max - Load-v8-gc-full-mark-compactor_max will be combined into one metric: - v8-gc-full-mark-compactor_max Additionally GC metrics now ignore GC events forced by the runner and report only the top GC phases, which reduces number of results. BUG=catapult:#2444 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c3e989de9c0b009bbcfd27f3652e6b71fbb8ee6e

Patch Set 1 : x #

Patch Set 2 : x #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -79 lines) Patch
M tracing/tracing/metrics/v8/gc_metric.html View 1 2 4 chunks +59 lines, -58 lines 0 comments Download
M tracing/tracing/metrics/v8/gc_metric_test.html View 3 chunks +7 lines, -11 lines 0 comments Download
M tracing/tracing/metrics/v8/utils.html View 5 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ulan
Hannes, ptal. Ethan, feel free to check style and rubber-stamp.
4 years, 5 months ago (2016-06-30 17:09:52 UTC) #6
eakuefner
lgtm from my perspective
4 years, 5 months ago (2016-06-30 19:58:45 UTC) #7
Hannes Payer (out of office)
lgtm
4 years, 5 months ago (2016-07-04 11:11:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106743005/60001
4 years, 5 months ago (2016-07-04 16:49:04 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 17:13:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698