MD Settings: Improve rendering performance of fonts page.

chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index cc724f5cede26e2173d81c95c27a0e523ddc4ef0..234531cca070795b8c54c0880df539566d62e656 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -1,7 +1,7 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/paper-dropdown-menu.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item-shared-styles.html">

[michaelpg, 2016/06/29 19:49:14]

alphabetize

[dpapad, 2016/06/29 20:50:08]

Done.

 <link rel="import" href="/controls/pref_control_behavior.html">
 <link rel="import" href="/i18n_setup.html">
 <link rel="import" href="/prefs/pref_util.html">
@@ -9,8 +9,8 @@
 
 <dom-module id="settings-dropdown-menu">
   <template>
-    <style include="settings-shared">
-      paper-item {
+    <style include="settings-shared paper-item-shared-styles">
+      .paper-item {
         color: var(--paper-grey-800);
         font-size: inherit;
       }
@@ -31,13 +31,14 @@
         disabled="[[shouldDisableMenu_(disabled, menuOptions.*)]]">
       <paper-listbox class="dropdown-content" selected="{{selected_}}"
           attr-for-selected="data-value">
-        <template is="dom-repeat" items="[[menuOptions]]">
-          <paper-item data-value$="[[item.value]]">[[item.name]]</paper-item>
+        <template is="dom-repeat" items="[[menuOptions]]" item-count="5">
+          <button class="paper-item"

[michaelpg, 2016/06/29 19:49:14]

the docs suggest including role="option". i assume that's an a11y thing but
haven't looked into it... is there a reason you dropped it?

[dpapad, 2016/06/29 20:50:08]

Done, just forgot about it.

+            data-value$="[[item.value]]">[[item.name]]</button>

[michaelpg, 2016/06/29 19:49:14]

4-space indent
nit: line break after > and before </button> like lines 38-41

[dpapad, 2016/06/29 20:50:08]

Fixed.

         </template>
-        <paper-item data-value$="[[notFoundValue_]]"
+        <button class="paper-item" data-value$="[[notFoundValue_]]"
             hidden$="[[!isSelectedNotFound_(selected_)]]">
           $i18n{custom}
-        </paper-item>
+        </button>
       </paper-listbox>
     </paper-dropdown-menu>
   </template>