Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.h

Issue 2106693002: Convert EmbeddedWorker to InterfaceRegistry/Provider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.h
diff --git a/content/browser/service_worker/embedded_worker_test_helper.h b/content/browser/service_worker/embedded_worker_test_helper.h
index 5874895a1312ae95a227f339e195a2073c8cb7e4..f875d654be755ff29860c1bb27124b1aadde507e 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.h
+++ b/content/browser/service_worker/embedded_worker_test_helper.h
@@ -12,7 +12,7 @@
#include <vector>
#include "base/callback.h"
-#include "base/containers/scoped_ptr_hash_map.h"
+#include "base/containers/hash_tables.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "content/common/mojo/service_registry_impl.h"
@@ -120,8 +120,8 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
const IPC::Message& message);
// Called to setup mojo for a new embedded worker. Override to register
- // services the worker should expose to the browser.
- virtual void OnSetupMojo(ServiceRegistry* service_registry);
+ // interfaces the worker should expose to the browser.
+ virtual void OnSetupMojo(shell::InterfaceRegistry* interface_registry);
// On*Event handlers. Called by the default implementation of
// OnMessageToWorker when events are sent to the embedded
@@ -151,6 +151,10 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
EmbeddedWorkerRegistry* registry();
private:
+ using InterfaceRegistryAndProvider =
+ std::pair<std::unique_ptr<shell::InterfaceRegistry>,
+ std::unique_ptr<shell::InterfaceProvider>>;
+
class MockEmbeddedWorkerSetup;
void OnStartWorkerStub(const EmbeddedWorkerMsg_StartWorker_Params& params);
@@ -188,9 +192,9 @@ class EmbeddedWorkerTestHelper : public IPC::Sender,
std::map<int, int64_t> embedded_worker_id_service_worker_version_id_map_;
- // Stores the ServiceRegistries that are associated with each individual
- // service worker.
- base::ScopedPtrHashMap<int, std::unique_ptr<ServiceRegistryImpl>>
+ // Stores the InterfaceRegistry/InterfaceProviders that are associated with
+ // each individual service worker.
+ base::hash_map<int, InterfaceRegistryAndProvider>
thread_id_service_registry_map_;
// Updated each time MessageToWorker message is received.

Powered by Google App Engine
This is Rietveld 408576698