Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 2106693002: Convert EmbeddedWorker to InterfaceRegistry/Provider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/embedded_worker_instance.h" 5 #include "content/browser/service_worker/embedded_worker_instance.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/metrics/histogram_macros.h" 12 #include "base/metrics/histogram_macros.h"
13 #include "base/threading/non_thread_safe.h" 13 #include "base/threading/non_thread_safe.h"
14 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
15 #include "content/browser/devtools/service_worker_devtools_manager.h" 15 #include "content/browser/devtools/service_worker_devtools_manager.h"
16 #include "content/browser/service_worker/embedded_worker_registry.h" 16 #include "content/browser/service_worker/embedded_worker_registry.h"
17 #include "content/browser/service_worker/embedded_worker_status.h" 17 #include "content/browser/service_worker/embedded_worker_status.h"
18 #include "content/browser/service_worker/service_worker_context_core.h" 18 #include "content/browser/service_worker/service_worker_context_core.h"
19 #include "content/common/content_switches_internal.h" 19 #include "content/common/content_switches_internal.h"
20 #include "content/common/mojo/service_registry_impl.h"
21 #include "content/common/service_worker/embedded_worker_messages.h" 20 #include "content/common/service_worker/embedded_worker_messages.h"
22 #include "content/common/service_worker/embedded_worker_settings.h" 21 #include "content/common/service_worker/embedded_worker_settings.h"
23 #include "content/common/service_worker/embedded_worker_setup.mojom.h" 22 #include "content/common/service_worker/embedded_worker_setup.mojom.h"
24 #include "content/common/service_worker/service_worker_types.h" 23 #include "content/common/service_worker/service_worker_types.h"
25 #include "content/public/browser/browser_thread.h" 24 #include "content/public/browser/browser_thread.h"
26 #include "content/public/browser/content_browser_client.h" 25 #include "content/public/browser/content_browser_client.h"
27 #include "content/public/browser/render_process_host.h" 26 #include "content/public/browser/render_process_host.h"
28 #include "content/public/common/child_process_host.h" 27 #include "content/public/common/child_process_host.h"
29 #include "ipc/ipc_message.h" 28 #include "ipc/ipc_message.h"
30 #include "services/shell/public/cpp/interface_provider.h" 29 #include "services/shell/public/cpp/interface_provider.h"
30 #include "services/shell/public/cpp/interface_registry.h"
31 #include "url/gurl.h" 31 #include "url/gurl.h"
32 32
33 namespace content { 33 namespace content {
34 34
35 namespace { 35 namespace {
36 36
37 // When a service worker version's failure count exceeds 37 // When a service worker version's failure count exceeds
38 // |kMaxSameProcessFailureCount|, the embedded worker is forced to start in a 38 // |kMaxSameProcessFailureCount|, the embedded worker is forced to start in a
39 // new process. 39 // new process.
40 const int kMaxSameProcessFailureCount = 2; 40 const int kMaxSameProcessFailureCount = 2;
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 } 97 }
98 BrowserThread::PostTask( 98 BrowserThread::PostTask(
99 BrowserThread::IO, 99 BrowserThread::IO,
100 FROM_HERE, 100 FROM_HERE,
101 base::Bind(callback, worker_devtools_agent_route_id, wait_for_debugger)); 101 base::Bind(callback, worker_devtools_agent_route_id, wait_for_debugger));
102 } 102 }
103 103
104 void SetupMojoOnUIThread( 104 void SetupMojoOnUIThread(
105 int process_id, 105 int process_id,
106 int thread_id, 106 int thread_id,
107 shell::mojom::InterfaceProviderRequest services, 107 shell::mojom::InterfaceProviderRequest remote_interfaces,
108 shell::mojom::InterfaceProviderPtrInfo exposed_services) { 108 shell::mojom::InterfaceProviderPtrInfo exposed_interfaces) {
109 RenderProcessHost* rph = RenderProcessHost::FromID(process_id); 109 RenderProcessHost* rph = RenderProcessHost::FromID(process_id);
110 // |rph| or its InterfaceProvider may be NULL in unit tests. 110 // |rph| or its InterfaceProvider may be NULL in unit tests.
111 if (!rph || !rph->GetRemoteInterfaces()) 111 if (!rph || !rph->GetRemoteInterfaces())
112 return; 112 return;
113 mojom::EmbeddedWorkerSetupPtr setup; 113 mojom::EmbeddedWorkerSetupPtr setup;
114 rph->GetRemoteInterfaces()->GetInterface(&setup); 114 rph->GetRemoteInterfaces()->GetInterface(&setup);
115 setup->ExchangeInterfaceProviders( 115 setup->ExchangeInterfaceProviders(
116 thread_id, std::move(services), 116 thread_id, std::move(remote_interfaces),
117 mojo::MakeProxy(std::move(exposed_services))); 117 mojo::MakeProxy(std::move(exposed_interfaces)));
118 } 118 }
119 119
120 } // namespace 120 } // namespace
121 121
122 // Lives on IO thread, proxies notifications to DevToolsManager that lives on 122 // Lives on IO thread, proxies notifications to DevToolsManager that lives on
123 // UI thread. Owned by EmbeddedWorkerInstance. 123 // UI thread. Owned by EmbeddedWorkerInstance.
124 class EmbeddedWorkerInstance::DevToolsProxy : public base::NonThreadSafe { 124 class EmbeddedWorkerInstance::DevToolsProxy : public base::NonThreadSafe {
125 public: 125 public:
126 DevToolsProxy(int process_id, int agent_route_id) 126 DevToolsProxy(int process_id, int agent_route_id)
127 : process_id_(process_id), 127 : process_id_(process_id),
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 return; 432 return;
433 } 433 }
434 DCHECK(status_ == EmbeddedWorkerStatus::STOPPED); 434 DCHECK(status_ == EmbeddedWorkerStatus::STOPPED);
435 435
436 DCHECK(!params->pause_after_download || !params->is_installed); 436 DCHECK(!params->pause_after_download || !params->is_installed);
437 DCHECK_NE(kInvalidServiceWorkerVersionId, params->service_worker_version_id); 437 DCHECK_NE(kInvalidServiceWorkerVersionId, params->service_worker_version_id);
438 step_time_ = base::TimeTicks::Now(); 438 step_time_ = base::TimeTicks::Now();
439 status_ = EmbeddedWorkerStatus::STARTING; 439 status_ = EmbeddedWorkerStatus::STARTING;
440 starting_phase_ = ALLOCATING_PROCESS; 440 starting_phase_ = ALLOCATING_PROCESS;
441 network_accessed_for_script_ = false; 441 network_accessed_for_script_ = false;
442 service_registry_.reset(new ServiceRegistryImpl()); 442 interface_registry_.reset(new shell::InterfaceRegistry(nullptr));
443 remote_interfaces_.reset(new shell::InterfaceProvider);
443 FOR_EACH_OBSERVER(Listener, listener_list_, OnStarting()); 444 FOR_EACH_OBSERVER(Listener, listener_list_, OnStarting());
444 445
445 params->embedded_worker_id = embedded_worker_id_; 446 params->embedded_worker_id = embedded_worker_id_;
446 params->worker_devtools_agent_route_id = MSG_ROUTING_NONE; 447 params->worker_devtools_agent_route_id = MSG_ROUTING_NONE;
447 params->wait_for_debugger = false; 448 params->wait_for_debugger = false;
448 params->settings.v8_cache_options = GetV8CacheOptions(); 449 params->settings.v8_cache_options = GetV8CacheOptions();
449 450
450 inflight_start_task_.reset(new StartTask(this, params->script_url)); 451 inflight_start_task_.reset(new StartTask(this, params->script_url));
451 inflight_start_task_->Start(std::move(params), callback); 452 inflight_start_task_->Start(std::move(params), callback);
452 } 453 }
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
498 499
499 void EmbeddedWorkerInstance::ResumeAfterDownload() { 500 void EmbeddedWorkerInstance::ResumeAfterDownload() {
500 if (process_id() == ChildProcessHost::kInvalidUniqueID || 501 if (process_id() == ChildProcessHost::kInvalidUniqueID ||
501 status_ != EmbeddedWorkerStatus::STARTING) { 502 status_ != EmbeddedWorkerStatus::STARTING) {
502 return; 503 return;
503 } 504 }
504 registry_->Send(process_id(), new EmbeddedWorkerMsg_ResumeAfterDownload( 505 registry_->Send(process_id(), new EmbeddedWorkerMsg_ResumeAfterDownload(
505 embedded_worker_id_)); 506 embedded_worker_id_));
506 } 507 }
507 508
508 ServiceRegistry* EmbeddedWorkerInstance::GetServiceRegistry() { 509 shell::InterfaceRegistry* EmbeddedWorkerInstance::GetInterfaceRegistry() {
509 DCHECK(status_ == EmbeddedWorkerStatus::STARTING || 510 DCHECK(status_ == EmbeddedWorkerStatus::STARTING ||
510 status_ == EmbeddedWorkerStatus::RUNNING) 511 status_ == EmbeddedWorkerStatus::RUNNING)
511 << static_cast<int>(status_); 512 << static_cast<int>(status_);
512 return service_registry_.get(); 513 return interface_registry_.get();
514 }
515
516 shell::InterfaceProvider* EmbeddedWorkerInstance::GetRemoteInterfaces() {
517 DCHECK(status_ == EmbeddedWorkerStatus::STARTING ||
518 status_ == EmbeddedWorkerStatus::RUNNING)
519 << static_cast<int>(status_);
520 return remote_interfaces_.get();
513 } 521 }
514 522
515 EmbeddedWorkerInstance::EmbeddedWorkerInstance( 523 EmbeddedWorkerInstance::EmbeddedWorkerInstance(
516 base::WeakPtr<ServiceWorkerContextCore> context, 524 base::WeakPtr<ServiceWorkerContextCore> context,
517 int embedded_worker_id) 525 int embedded_worker_id)
518 : context_(context), 526 : context_(context),
519 registry_(context->embedded_worker_registry()), 527 registry_(context->embedded_worker_registry()),
520 embedded_worker_id_(embedded_worker_id), 528 embedded_worker_id_(embedded_worker_id),
521 status_(EmbeddedWorkerStatus::STOPPED), 529 status_(EmbeddedWorkerStatus::STOPPED),
522 starting_phase_(NOT_STARTING), 530 starting_phase_(NOT_STARTING),
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 starting_phase_ = THREAD_STARTED; 647 starting_phase_ = THREAD_STARTED;
640 if (!step_time_.is_null()) { 648 if (!step_time_.is_null()) {
641 base::TimeDelta duration = UpdateStepTime(); 649 base::TimeDelta duration = UpdateStepTime();
642 if (inflight_start_task_->is_installed()) 650 if (inflight_start_task_->is_installed())
643 ServiceWorkerMetrics::RecordTimeToStartThread(duration, start_situation_); 651 ServiceWorkerMetrics::RecordTimeToStartThread(duration, start_situation_);
644 } 652 }
645 653
646 thread_id_ = thread_id; 654 thread_id_ = thread_id;
647 FOR_EACH_OBSERVER(Listener, listener_list_, OnThreadStarted()); 655 FOR_EACH_OBSERVER(Listener, listener_list_, OnThreadStarted());
648 656
649 shell::mojom::InterfaceProviderPtr exposed_services; 657 shell::mojom::InterfaceProviderPtr exposed_interfaces;
650 service_registry_->Bind(GetProxy(&exposed_services)); 658 interface_registry_->Bind(GetProxy(&exposed_interfaces));
651 shell::mojom::InterfaceProviderRequest request = 659 shell::mojom::InterfaceProviderPtr remote_interfaces;
652 service_registry_->TakeRemoteRequest(); 660 shell::mojom::InterfaceProviderRequest request = GetProxy(&remote_interfaces);
661 remote_interfaces_->Bind(std::move(remote_interfaces));
653 BrowserThread::PostTask( 662 BrowserThread::PostTask(
654 BrowserThread::UI, FROM_HERE, 663 BrowserThread::UI, FROM_HERE,
655 base::Bind(SetupMojoOnUIThread, process_id(), thread_id_, 664 base::Bind(SetupMojoOnUIThread, process_id(), thread_id_,
656 base::Passed(&request), 665 base::Passed(&request),
657 base::Passed(exposed_services.PassInterface()))); 666 base::Passed(exposed_interfaces.PassInterface())));
658 } 667 }
659 668
660 void EmbeddedWorkerInstance::OnScriptLoadFailed() { 669 void EmbeddedWorkerInstance::OnScriptLoadFailed() {
661 if (!inflight_start_task_) 670 if (!inflight_start_task_)
662 return; 671 return;
663 TRACE_EVENT_ASYNC_STEP_PAST0("ServiceWorker", "EmbeddedWorkerInstance::Start", 672 TRACE_EVENT_ASYNC_STEP_PAST0("ServiceWorker", "EmbeddedWorkerInstance::Start",
664 inflight_start_task_.get(), 673 inflight_start_task_.get(),
665 "OnScriptLoadFailed"); 674 "OnScriptLoadFailed");
666 FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoadFailed()); 675 FOR_EACH_OBSERVER(Listener, listener_list_, OnScriptLoadFailed());
667 } 676 }
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 } 799 }
791 800
792 void EmbeddedWorkerInstance::ReleaseProcess() { 801 void EmbeddedWorkerInstance::ReleaseProcess() {
793 // Abort an inflight start task. 802 // Abort an inflight start task.
794 inflight_start_task_.reset(); 803 inflight_start_task_.reset();
795 804
796 devtools_proxy_.reset(); 805 devtools_proxy_.reset();
797 process_handle_.reset(); 806 process_handle_.reset();
798 status_ = EmbeddedWorkerStatus::STOPPED; 807 status_ = EmbeddedWorkerStatus::STOPPED;
799 thread_id_ = kInvalidEmbeddedWorkerThreadId; 808 thread_id_ = kInvalidEmbeddedWorkerThreadId;
800 service_registry_.reset(); 809 interface_registry_.reset();
810 remote_interfaces_.reset();
801 } 811 }
802 812
803 void EmbeddedWorkerInstance::OnStartFailed(const StatusCallback& callback, 813 void EmbeddedWorkerInstance::OnStartFailed(const StatusCallback& callback,
804 ServiceWorkerStatusCode status) { 814 ServiceWorkerStatusCode status) {
805 EmbeddedWorkerStatus old_status = status_; 815 EmbeddedWorkerStatus old_status = status_;
806 ReleaseProcess(); 816 ReleaseProcess();
807 base::WeakPtr<EmbeddedWorkerInstance> weak_this = weak_factory_.GetWeakPtr(); 817 base::WeakPtr<EmbeddedWorkerInstance> weak_this = weak_factory_.GetWeakPtr();
808 callback.Run(status); 818 callback.Run(status);
809 if (weak_this && old_status != EmbeddedWorkerStatus::STOPPED) 819 if (weak_this && old_status != EmbeddedWorkerStatus::STOPPED)
810 FOR_EACH_OBSERVER(Listener, weak_this->listener_list_, 820 FOR_EACH_OBSERVER(Listener, weak_this->listener_list_,
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 case SCRIPT_READ_FINISHED: 881 case SCRIPT_READ_FINISHED:
872 return "Script read finished"; 882 return "Script read finished";
873 case STARTING_PHASE_MAX_VALUE: 883 case STARTING_PHASE_MAX_VALUE:
874 NOTREACHED(); 884 NOTREACHED();
875 } 885 }
876 NOTREACHED() << phase; 886 NOTREACHED() << phase;
877 return std::string(); 887 return std::string();
878 } 888 }
879 889
880 } // namespace content 890 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698