Issue 2106683003: [wasm] Making compare and conditionals more correct.

Issue 2106683003: [wasm] Making compare and conditionals more correct. (Closed)

Created:
4 years, 5 months ago by bradnelson

Modified:
4 years, 5 months ago

Reviewers:
aseemgarg, bradn

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[wasm] Making compare and conditionals more correct. Comparisons were allowing asm 'int' values in places that require strict 'signed' or 'unsigned' but not both. Fixes crash when these make it to asm-wasm. BUG=599413 BUG=v8:4203 R=aseemgarg@chromium.org Committed: https://crrev.com/e42983d14707b8710e969d99a9e4793dd6da9d23 Cr-Commit-Position: refs/heads/master@{#37353}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -50 lines)			Patch
M	src/typing-asm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/typing-asm.cc	View	1 2	2 chunks	+24 lines, -17 lines	0 comments	Download
M	test/cctest/test-asm-validator.cc	View	1 2	8 chunks	+16 lines, -8 lines	0 comments	Download
A	test/mjsunit/regress/regress-wasm-crbug-599413.js	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	test/mjsunit/wasm/asm-wasm.js	View	1 2	19 chunks	+24 lines, -24 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106683003/40001

4 years, 5 months ago (2016-06-28 23:46:39 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 23:50:29 UTC) #8

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/e42983d14707b8710e969d99a9e4793dd6da9d23
Cr-Commit-Position: refs/heads/master@{#37353}